chore(api): clarify image fidelity and legacy image guidance - #3919
markstuart-oai wants to merge 1 commit into
Conversation
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed; 2 generated baselines changed. Compared
45 existing customizations unchanged
5 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35566134878 --repo openai/openai-python \
--name castiron-custom-code-35566134878-1 --dir /tmp/castiron-custom-code-35566134878-1
git apply --stat /tmp/castiron-custom-code-35566134878-1/custom-code.patch
cat /tmp/castiron-custom-code-35566134878-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 69a2c1db6feacf32be6693809e7cab1c3b49cad7 11f6ecff0e76bd6d622bd81b3de8e88c160b4059
python3 scripts/castiron/custom_code_report.py report \
--base 69a2c1db6feacf32be6693809e7cab1c3b49cad7 \
--head 11f6ecff0e76bd6d622bd81b3de8e88c160b4059 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-11f6ecff0e76
cat /tmp/castiron-custom-code-11f6ecff0e76/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0a9c0d7ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e0a9c0d to
3b764ed
Compare
3b764ed to
b3da684
Compare
Castiron-Internal-PR: openai/openai-python-internal#124 Castiron-Source-SHA: d84f221f4059cad13dcd92d937dd0570cecc8abc Castiron-Public-Base-SHA: 69a2c1d
b3da684 to
11f6ecf
Compare
Clarifies image fidelity guidance: the low default applies to supporting models, mini retains its low-only exception, and unsupported models require omission. Stable/beta image-tool help names both image-2 identifiers explicitly. Labels retired DALL·E settings and variations as legacy and directs callers toward supported image workflows with an explicit model choice.
No image request types, enum values, defaults, nullability or serialization change.
Validation: AST and snapshot comparisons confirm all Python changes are documentation-only. Existing focused import/event/credential/storage checks passed (32 tests); runtime and test code are unchanged.