fix(api): preserve audio formats and diarized transcription types - #3920
markstuart-oai wants to merge 1 commit into
Conversation
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed; 2 generated baselines changed. Compared
45 existing customizations unchanged
5 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35567292918 --repo openai/openai-python \
--name castiron-custom-code-35567292918-1 --dir /tmp/castiron-custom-code-35567292918-1
git apply --stat /tmp/castiron-custom-code-35567292918-1/custom-code.patch
cat /tmp/castiron-custom-code-35567292918-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 69a2c1db6feacf32be6693809e7cab1c3b49cad7 60aed096148bdc1527a1d1c0e0f3ca61842f28f4
python3 scripts/castiron/custom_code_report.py report \
--base 69a2c1db6feacf32be6693809e7cab1c3b49cad7 \
--head 60aed096148bdc1527a1d1c0e0f3ca61842f28f4 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-60aed096148b
cat /tmp/castiron-custom-code-60aed096148b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
fbb34fe to
287414a
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Castiron-Internal-PR: openai/openai-python-internal#121 Castiron-Source-SHA: f1cabf8850274ebf78d553df3bc1c5b11b7bebb4 Castiron-Public-Base-SHA: 69a2c1d
287414a to
60aed09
Compare
markstuart-oai
changed the title
2 participants
Summary
Preserves complete audio responses, sends structured chunking strategies correctly, and narrows async diarized transcription return types.
Changes
diarized_jsoncalls while preserving broad and streaming overloads.extra_bodyoverrides, preserving zero,auto, null, omission and caller-owned inputs.Related reports: transcription plaintext media, speech media types, and overlapping transcription response shapes.