Skip to content

fix(api): correct tool and tool-output schema tags - #3924

Open
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-129
Open

markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-129

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Clarifies tool-output content tags and the apply-patch tool tag while preserving existing tool types.

Changes

  • Associates text, image and file tool outputs with their existing content variants.
  • Associates apply_patch with its existing tool schema in the stable and Beta API references.
  • Preserves existing tool type names and constructors.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

47 mixed files remain; 0 existing customizations changed.

Compared 69a2c1db6fea323a092d0129. Generated baselines verified.

47 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/responses_client_event.py
  • src/openai/types/responses/responses_client_event_param.py

7 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35576165858 --repo openai/openai-python \
  --name castiron-custom-code-35576165858-1 --dir /tmp/castiron-custom-code-35576165858-1
git apply --stat /tmp/castiron-custom-code-35576165858-1/custom-code.patch
cat /tmp/castiron-custom-code-35576165858-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 69a2c1db6feacf32be6693809e7cab1c3b49cad7 323a092d0129408c586918d922f90bea0e390720
python3 scripts/castiron/custom_code_report.py report \
  --base 69a2c1db6feacf32be6693809e7cab1c3b49cad7 \
  --head 323a092d0129408c586918d922f90bea0e390720 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-323a092d0129
cat /tmp/castiron-custom-code-323a092d0129/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 21, 2026 05:32
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 21, 2026 05:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T08:06:26.187514Z 323a092 New commits
🔒 Security Review Completed 2026-09-21T08:08:10.909708Z 323a092 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

236/236 SDK tests passed in 13.567s for Python SDK PR #3924.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 212ms
tests/chat-completions-create.test.ts ✅ Passed 426ms
tests/chat-completions-stream.test.ts ✅ Passed 428ms
tests/files-content-binary.test.ts ✅ Passed 278ms
tests/files-create-multipart.test.ts ✅ Passed 310ms
tests/files-list-pagination.test.ts ✅ Passed 202ms
tests/initialize-config.test.ts ✅ Passed 412ms
tests/instance-isolation.test.ts ✅ Passed 322ms
tests/models-list.test.ts ✅ Passed 380ms
tests/responses-background-lifecycle.test.ts ✅ Passed 369ms
tests/responses-body-method-errors.test.ts ✅ Passed 388ms
tests/responses-cancel-timeout.test.ts ✅ Passed 202ms
tests/responses-cancel.test.ts ✅ Passed 321ms
tests/responses-compact-retries.test.ts ✅ Passed 451ms
tests/responses-compact.test.ts ✅ Passed 426ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 130ms
tests/responses-create-advanced.test.ts ✅ Passed 343ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.306s
tests/responses-create-errors.test.ts ✅ Passed 212ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 430ms
tests/responses-create-retries.test.ts ✅ Passed 713ms
tests/responses-create-stream-failures.test.ts ✅ Passed 960ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 295ms
tests/responses-create-stream-wire.test.ts ✅ Passed 3.537s
tests/responses-create-stream.test.ts ✅ Passed 183ms
tests/responses-create-terminal-states.test.ts ✅ Passed 269ms
tests/responses-create-timeout.test.ts ✅ Passed 209ms
tests/responses-create.test.ts ✅ Passed 316ms
tests/responses-delete.test.ts ✅ Passed 311ms
tests/responses-input-items-errors.test.ts ✅ Passed 836ms
tests/responses-input-items-list.test.ts ✅ Passed 470ms
tests/responses-input-items-options.test.ts ✅ Passed 407ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 279ms
tests/responses-input-tokens-count.test.ts ✅ Passed 350ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.594s
tests/responses-not-found-errors.test.ts ✅ Passed 302ms
tests/responses-parse.test.ts ✅ Passed 394ms
tests/responses-retrieve-retries.test.ts ✅ Passed 332ms
tests/responses-retrieve.test.ts ✅ Passed 340ms
tests/responses-stored-method-errors.test.ts ✅ Passed 618ms
tests/retry-behavior.test.ts ✅ Passed 3.265s
tests/sdk-error-shape.test.ts ✅ Passed 304ms

View OkTest run #35575994850

SDK merge (866ef3c5f9c3) · head (323a092d0129) · base (69a2c1db6fea) · OkTest (a0be4375e02d)

Castiron-Internal-PR: openai/openai-python-internal#129
Castiron-Source-SHA: 31e15a5dd49639e813ecd0d07880c054d9e7dd4c
Castiron-Public-Base-SHA: 69a2c1d
@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-129 branch from 27b7c2a to 323a092 Compare September 21, 2026 08:04
@markstuart-oai markstuart-oai changed the title fix(api): correct tool output content schema tags fix(api): correct tool and tool-output schema tags Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants