Conversation
Add AbortSignal.timeout on live llms-full fetches and bound r2-pages token verify curl plus credential mint fetch. Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
llms-full.ymlstill does livefetchwithoutAbortSignal.r2-pages.ymltoken verify usescurl -fsSwith no--max-time, and the credential mintfetchhas no abort. Sibling live-smoke and cutover scripts already bound those calls.Evidence
Terminal output from the workflow contract checks:
Real behavior proof
AbortSignal.timeout(30_000). Token verify curls use--max-time 30. The temp-access-credentials fetch uses the same abort signal.Summary
Bound the remaining llms-full and r2-pages network calls.