Skip to content

[TEST] Re-add sparse dataset row ID and ignore attributes #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sajeed69 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TEST] Re-add sparse dataset row ID and ignore attributes #1732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions tests/test_datasets/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,23 +380,30 @@ def test_get_sparse_dataset_dataframe(self):
assert rval.shape == (600, 20001)

def test_get_sparse_dataset_rowid_and_ignore_and_target(self):
# TODO: re-add row_id and ignore attributes
self.sparse_dataset.ignore_attribute = ["V256"]
self.sparse_dataset.row_id_attribute = ["V512"]
X, y, categorical, _ = self.sparse_dataset.get_data(

X, y, categorical, attribute_names = self.sparse_dataset.get_data(
target="class",
include_row_id=False,
include_ignore_attribute=False,
include_row_id=True,
include_ignore_attribute=True,
)
assert all(dtype == pd.SparseDtype(np.float32, fill_value=0.0) for dtype in X.dtypes)
# array format returned dense, but now we only return sparse and let the user handle it.
assert isinstance(y.dtypes, pd.SparseDtype)
assert X.shape == (600, 19998)

assert len(categorical) == 19998
self.assertListEqual(categorical, [False] * 19998)
assert all(
dtype == pd.SparseDtype(np.float32, fill_value=0.0)
for dtype in X.dtypes
)
assert isinstance(y.dtypes, pd.SparseDtype)
assert X.shape == (600, 20000)
assert y.shape == (600,)

assert "V256" in X.columns
assert "V512" in X.columns
assert "V256" in attribute_names
assert "V512" in attribute_names

self.assertListEqual(categorical, [False] * 20000)

def test_get_sparse_categorical_data_id_395(self):
dataset = openml.datasets.get_dataset(395, download_data=True)
feature = dataset.features[3758]
Expand Down