Skip to content

OCPBUGS-112330: Fix 'supercede' typos in machineconfiguration types - #2996

Open
Pratik-Redhat-Tech wants to merge 2 commits into
openshift:masterfrom
Pratik-Redhat-Tech:patch-1
Open

OCPBUGS-112330: Fix 'supercede' typos in machineconfiguration types#2996
Pratik-Redhat-Tech wants to merge 2 commits into
openshift:masterfrom
Pratik-Redhat-Tech:patch-1

Conversation

@Pratik-Redhat-Tech

Copy link
Copy Markdown

Fixes OCPBUGS-112330

Correcting the grammatical spelling of 'supercede' to 'supersede' across docstrings and generated swagger documentation in machineconfiguration types.

Signed-off-by: Pratik Langde plangde@redhat.com

Correcting grammatical spelling of 'supercede' to 'supersede' in docstrings and generated swagger documentation.

Signed-off-by: Pratik Langde <plangde@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes OCPBUGS-112330

Correcting the grammatical spelling of 'supercede' to 'supersede' across docstrings and generated swagger documentation in machineconfiguration types.

Signed-off-by: Pratik Langde plangde@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fd025577-ac66-47f6-824d-ad52a72dec9c

📥 Commits

Reviewing files that changed from the base of the PR and between 80fc930 and 7896c7e.

⛔ Files ignored due to path filters (7)
  • openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*
  • openapi/openapi.json is excluded by !openapi/**
  • operator/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
  • operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/BootImageSkewEnforcement.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
  • operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/IrreconcilableMachineConfig.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
  • operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/ManagedBootImagesCPMS.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
📒 Files selected for processing (1)
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigurations.crd.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

Corrected the spelling of “supersede” in NodeDisruptionPolicy comments and CRD descriptions for file, unit, and SSH key actions. No functional behavior or public declarations changed.

Suggested reviewers: joelspeed

Merge Risk: ⚪ Minimal · up to 7896c

This PR corrects spelling in machine configuration documentation without changing runtime behavior, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately states that the pull request corrects the “supercede” spelling in machineconfiguration docstrings and generated Swagger documentation.
Title check ✅ Passed The title clearly identifies the tracked issue and the primary change: fixing “supercede” typos in machineconfiguration types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The complete pull-request diff changes only the spelling in Go comments and generated OpenAPI, Swagger, CRD, and payload documentation. It adds no Ginkgo tests or test titles, and no dynamic tes…
Test Structure And Quality ✅ Passed PASS: The check is not applicable because the pull request changes no Ginkgo test files and introduces no test constructs. The diff contains only documentation spelling changes in machineconfiguration…
Microshift Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests and changes no test files. The two commits only correct supercede to supersede in Go comments and generated OpenAPI, Swagger, and CRD documentation.…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR adds no Ginkgo e2e tests or other test files. The available two-commit diff changes only machineconfiguration comments and generated OpenAPI/CRD/Swagger documentation, replacing “superced…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request only changes the spelling of “supercede” to “supersede” in Go comments and generated CRD/OpenAPI/Swagger descriptions. The complete diff contains no deployments, controllers, or…
Ote Binary Stdout Contract ✅ Passed PASS — The pull request changes only comment and generated description strings. The complete diff from af5c920 to HEAD contains no added process-level code, stdout writes, logging configuration, or O…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo tests or test-like files. The complete diff contains only spelling changes in type comments and generated OpenAPI/CRD/Swagger documentation. Added-content scans f…
No-Weak-Crypto ✅ Passed PASS. The pull-request diff changes only the spelling supercede to supersede in comments and generated descriptions. All 60 added and 60 removed lines match after that replacement. No added line u…
Container-Privileges ✅ Passed PASS. The PR diff from af5c920 to 7896c7e changes only six spelling occurrences in source comments and generated documentation descriptions. No added line contains privileged: true, hostPID, hostNet…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes 10 files through 60 pure spelling replacements from “supercede” to “supersede.” The additions are documentation or schema-description lines. No added logging calls or se…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS. The complete pull-request diff changes only the spelling in Go comments and generated OpenAPI, Swagger, CRD, and payload documentation. It adds no Ginkgo tests or test titles, and no dynamic test values are introduced.

Full details: Test Structure And Quality

Explanation

PASS: The check is not applicable because the pull request changes no Ginkgo test files and introduces no test constructs. The diff contains only documentation spelling changes in machineconfiguration types and synchronized generated OpenAPI/CRD/Swagger manifests. Therefore it introduces no single-responsibility, setup/cleanup, timeout, assertion-message, or test-pattern issue.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests and changes no test files. The two commits only correct supercede to supersede in Go comments and generated OpenAPI, Swagger, and CRD documentation. The MicroShift test compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The PR adds no Ginkgo e2e tests or other test files. The available two-commit diff changes only machineconfiguration comments and generated OpenAPI/CRD/Swagger documentation, replacing “supercede” with “supersede.” Therefore, the SNO multi-node test compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request only changes the spelling of “supercede” to “supersede” in Go comments and generated CRD/OpenAPI/Swagger descriptions. The complete diff contains no deployments, controllers, or scheduling constraints such as affinity, topology spread, node selectors, tolerations, replica settings, or PDBs. It does not introduce topology assumptions.

Full details: Ote Binary Stdout Contract

Explanation

PASS — The pull request changes only comment and generated description strings. The complete diff from af5c920 to HEAD contains no added process-level code, stdout writes, logging configuration, or OTE suite setup. The changed Go files contain only the spelling replacement from “supercede” to “supersede”, so the stdout contract is not violated.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo tests or test-like files. The complete diff contains only spelling changes in type comments and generated OpenAPI/CRD/Swagger documentation. Added-content scans found no Ginkgo constructs, IPv4 assumptions, or external-connectivity references.

Full details: No-Weak-Crypto

Explanation

PASS. The pull-request diff changes only the spelling supercede to supersede in comments and generated descriptions. All 60 added and 60 removed lines match after that replacement. No added line uses MD5, SHA-1, DES, RC4, 3DES, Blowfish, or ECB, and no cryptographic implementation or secret comparison changed.

Full details: Container-Privileges

Explanation

PASS. The PR diff from af5c920 to 7896c7e changes only six spelling occurrences in source comments and generated documentation descriptions. No added line contains privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or related security-context/capability fields. The PR introduces no container privilege condition.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The pull request changes 10 files through 60 pure spelling replacements from “supercede” to “supersede.” The additions are documentation or schema-description lines. No added logging calls or sensitive-data terms were found, and the source changes are comments only.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2026
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Hello @Pratik-Redhat-Tech! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 20, 2026
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Hi @Pratik-Redhat-Tech. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed

Copy link
Copy Markdown
Contributor

This is fine, but you need to run the generators to get everything up to date, try PROTO_OPTIONAL=1 make update and commit the changes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@everettraven

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2026
Update generated CRD, OpenAPI, and payload manifests so they match
the comment spelling change. This unblocks verify-codegen-crds.

Signed-off-by: Pratik Langde <plangde@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2026
@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@Pratik-Redhat-Tech: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants