OCPBUGS-112330: Fix 'supercede' typos in machineconfiguration types - #2996
OCPBUGS-112330: Fix 'supercede' typos in machineconfiguration types#2996Pratik-Redhat-Tech wants to merge 2 commits into
Conversation
Correcting grammatical spelling of 'supercede' to 'supersede' in docstrings and generated swagger documentation. Signed-off-by: Pratik Langde <plangde@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughCorrected the spelling of “supersede” in NodeDisruptionPolicy comments and CRD descriptions for file, unit, and SSH key actions. No functional behavior or public declarations changed. Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR corrects spelling in machine configuration documentation without changing runtime behavior, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The complete pull-request diff changes only the spelling in Go comments and generated OpenAPI, Swagger, CRD, and payload documentation. It adds no Ginkgo tests or test titles, and no dynamic test values are introduced. Full details: Test Structure And QualityExplanation PASS: The check is not applicable because the pull request changes no Ginkgo test files and introduces no test constructs. The diff contains only documentation spelling changes in machineconfiguration types and synchronized generated OpenAPI/CRD/Swagger manifests. Therefore it introduces no single-responsibility, setup/cleanup, timeout, assertion-message, or test-pattern issue. Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests and changes no test files. The two commits only correct Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The PR adds no Ginkgo e2e tests or other test files. The available two-commit diff changes only machineconfiguration comments and generated OpenAPI/CRD/Swagger documentation, replacing “supercede” with “supersede.” Therefore, the SNO multi-node test compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request only changes the spelling of “supercede” to “supersede” in Go comments and generated CRD/OpenAPI/Swagger descriptions. The complete diff contains no deployments, controllers, or scheduling constraints such as affinity, topology spread, node selectors, tolerations, replica settings, or PDBs. It does not introduce topology assumptions. Full details: Ote Binary Stdout ContractExplanation PASS — The pull request changes only comment and generated description strings. The complete diff from af5c920 to HEAD contains no added process-level code, stdout writes, logging configuration, or OTE suite setup. The changed Go files contain only the spelling replacement from “supercede” to “supersede”, so the stdout contract is not violated. Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds no Ginkgo tests or test-like files. The complete diff contains only spelling changes in type comments and generated OpenAPI/CRD/Swagger documentation. Added-content scans found no Ginkgo constructs, IPv4 assumptions, or external-connectivity references. Full details: No-Weak-CryptoExplanation PASS. The pull-request diff changes only the spelling Full details: Container-PrivilegesExplanation PASS. The PR diff from af5c920 to 7896c7e changes only six spelling occurrences in source comments and generated documentation descriptions. No added line contains privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or related security-context/capability fields. The PR introduces no container privilege condition. Full details: No-Sensitive-Data-In-LogsExplanation PASS. The pull request changes 10 files through 60 pure spelling replacements from “supercede” to “supersede.” The additions are documentation or schema-description lines. No added logging calls or sensitive-data terms were found, and the source changes are comments only. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello @Pratik-Redhat-Tech! Some important instructions when contributing to openshift/api: |
|
Hi @Pratik-Redhat-Tech. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This is fine, but you need to run the generators to get everything up to date, try |
|
/ok-to-test |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
Update generated CRD, OpenAPI, and payload manifests so they match the comment spelling change. This unblocks verify-codegen-crds. Signed-off-by: Pratik Langde <plangde@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
/jira refresh |
|
@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Pratik-Redhat-Tech: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
Fixes OCPBUGS-112330
Correcting the grammatical spelling of 'supercede' to 'supersede' across docstrings and generated swagger documentation in machineconfiguration types.
Signed-off-by: Pratik Langde plangde@redhat.com