OCPBUGS-105402: Remove EVPN feature gate by dasanind · Pull Request #3003 · openshift/api

dasanind · 2026-08-21T14:52:53Z

chore: OCPBUGS-105402: Remove EVPN feature gate

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate.
This commit removes:

FeatureGateEVPN definition from features/features.go
EVPN references from all payload manifest files
EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no longer required for cluster configuration.

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate. This commit removes: - FeatureGateEVPN definition from features/features.go - EVPN references from all payload manifest files - EVPN entry from features.md documentation The feature gate graduation is complete and the gate is no longer required for cluster configuration. Signed-off-by: Anindita Das <anidas@redhat.com>

openshift-merge-bot · 2026-08-21T14:52:56Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-21T14:52:59Z

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is invalid:

expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

chore: OCPBUGS-105402: Remove EVPN feature gate

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate.
This commit removes:

FeatureGateEVPN definition from features/features.go

EVPN references from all payload manifest files

EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no longer required for cluster configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-21T14:52:59Z

Hello @dasanind! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-08-21T14:53:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 458f3997-557d-4f20-b95f-2e69c1ef662d

📥 Commits

Reviewing files that changed from the base of the PR and between 445982f and 1d15fd8.

📒 Files selected for processing (10)

features.md
features/features.go
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (10)

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
features/features.go
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
features.md
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

📝 Walkthrough

Walkthrough

The change removes the exported FeatureGateEVPN registration and its profile settings. It also removes EVPN from the feature support matrix and affected 4.10 HyperShift and SelfManagedHA feature-gate manifests.

Suggested reviewers: sayan-biswas, everettraven

Merge Risk: ⚪ Minimal · up to 1d15f

This change removes the no-longer-needed EVPN feature gate and its manifest and documentation entries. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely states the primary change: removal of the EVPN feature gate.
Description check	✅ Passed	The description directly explains why the EVPN feature gate is removed and lists the affected declarations, manifests, and documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull-request diff removes the EVPN documentation row, feature-gate registration, and manifest entries. It adds no Ginkgo test titles and changes no `It`, `Describe`, `Context`, or `When` dec…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only feature-gate registration, manifests, and documentation. The verified diff contains 10 files and no test-related paths or Ginkgo test additions/deletions. Therefore…
Microshift Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests. The base-to-HEAD diff contains only deletions in `features.md`, `features/features.go`, and feature-gate manifests. It has no test-like paths, no added…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR adds no Ginkgo e2e tests. The verified patch changes only two .proto files, one Go feature declaration, one documentation file, and eight YAML manifests. No test paths or added Ginkgo dec…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull-request diff only removes the `EVPN` feature-gate registration, feature-gate manifest entries, and documentation. It does not add or modify deployments, controllers, pod scheduling fiel…
Ote Binary Stdout Contract	✅ Passed	PASS: The PR-side diff contains only deletions in feature metadata, one Go feature-gate declaration, and YAML manifests. It adds no `main`, `init`, Ginkgo suite setup, logging, or stdout write. The to…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull-request diff adds no files, lines, or Ginkgo e2e tests. The isolated diff contains only deletions from features.md, features/features.go, and feature-gate manifests, so the IPv6 and dis…
No-Weak-Crypto	✅ Passed	PASS. The effective PR diff (against the second merge parent) contains 0 added lines and 33 deleted lines. It only removes the EVPN feature-gate declaration and EVPN manifest/documentation entries. No…
Container-Privileges	✅ Passed	The pull-request-specific diff removes the `EVPN` feature gate from `features.md`, `features/features.go`, and eight `FeatureGate` manifests. The changed manifests are `kind: FeatureGate` objects and …
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull-request commit removes the EVPN declaration, documentation row, and manifest entries. Its only non-deletion changes are generated `.proto` annotations and options. Searches of the added…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull-request diff removes the EVPN documentation row, feature-gate registration, and manifest entries. It adds no Ginkgo test titles and changes no It, Describe, Context, or When declarations. The changed tests paths are YAML fixtures, not test-title code.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only feature-gate registration, manifests, and documentation. The verified diff contains 10 files and no test-related paths or Ginkgo test additions/deletions. Therefore, the stated Ginkgo test quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests. The base-to-HEAD diff contains only deletions in features.md, features/features.go, and feature-gate manifests. It has no test-like paths, no added lines, and the only changed Go file contains no It, Describe, Context, or When declarations. The MicroShift test-compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The PR adds no Ginkgo e2e tests. The verified patch changes only two .proto files, one Go feature declaration, one documentation file, and eight YAML manifests. No test paths or added Ginkgo declarations are present, so the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull-request diff only removes the EVPN feature-gate registration, feature-gate manifest entries, and documentation. It does not add or modify deployments, controllers, pod scheduling fields, affinities, topology spread constraints, replica logic, node selectors, tolerations, or PDBs. Therefore, it introduces no topology-unaware scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The PR-side diff contains only deletions in feature metadata, one Go feature-gate declaration, and YAML manifests. It adds no main, init, Ginkgo suite setup, logging, or stdout write. The touched files contain no stdout-related calls. The process-level entrypoints and suite hooks found in the repository are unchanged, so this PR introduces no OTE JSON/stdout contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull-request diff adds no files, lines, or Ginkgo e2e tests. The isolated diff contains only deletions from features.md, features/features.go, and feature-gate manifests, so the IPv6 and disconnected-network test check is not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The effective PR diff (against the second merge parent) contains 0 added lines and 33 deleted lines. It only removes the EVPN feature-gate declaration and EVPN manifest/documentation entries. No MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparison change was introduced.

Full details: Container-Privileges

Explanation

The pull-request-specific diff removes the EVPN feature gate from features.md, features/features.go, and eight FeatureGate manifests. The changed manifests are kind: FeatureGate objects and contain no container or pod security settings. No added line introduces privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or an explicit root configuration. The later merge commit contains unrelated changes, which were excluded from the causality assessment.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull-request commit removes the EVPN declaration, documentation row, and manifest entries. Its only non-deletion changes are generated .proto annotations and options. Searches of the added diff lines and all changed files found no logging calls or log configuration, and no passwords, tokens, API keys, PII, session IDs, hostnames, or customer data were added to logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-21T14:54:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dasanind · 2026-08-21T15:05:38Z

/jira refresh

openshift-ci-robot · 2026-08-21T15:05:43Z

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is invalid:

expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

everettraven · 2026-08-21T19:26:12Z

/pipeline auto

openshift-merge-bot · 2026-08-21T19:26:16Z

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

dasanind · 2026-08-24T14:03:58Z

/jira refresh

openshift-ci-robot · 2026-08-24T14:04:06Z

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.1.0) matches configured target version for branch (5.1.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dasanind · 2026-08-24T14:05:12Z

/retest

dasanind · 2026-08-24T15:01:04Z

/test verify

openshift-merge-bot · 2026-08-25T16:33:22Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

dasanind · 2026-08-25T19:35:31Z

/test e2e-aws-ovn

dasanind · 2026-08-25T19:46:33Z

/test e2e-aws-ovn-hypershift

dasanind · 2026-08-25T20:42:27Z

/test e2e-aws-ovn-hypershift-conformance

dasanind · 2026-08-25T20:44:36Z

/test e2e-aws-ovn-techpreview

dasanind · 2026-08-25T20:50:13Z

/retest

openshift-ci · 2026-08-26T02:11:42Z

@dasanind: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/minor-e2e-upgrade-minor	`1d15fd8`	link	true	`/test minor-e2e-upgrade-minor`
ci/prow/e2e-azure	`1d15fd8`	link	true	`/test e2e-azure`
ci/prow/e2e-gcp	`1d15fd8`	link	true	`/test e2e-gcp`
ci/prow/e2e-aws-serial-techpreview-1of2	`1d15fd8`	link	true	`/test e2e-aws-serial-techpreview-1of2`
ci/prow/e2e-aws-serial-2of2	`1d15fd8`	link	true	`/test e2e-aws-serial-2of2`
ci/prow/e2e-aws-ovn-hypershift-conformance	`1d15fd8`	link	true	`/test e2e-aws-ovn-hypershift-conformance`
ci/prow/e2e-upgrade-out-of-change	`1d15fd8`	link	true	`/test e2e-upgrade-out-of-change`
ci/prow/e2e-aws-serial-techpreview-2of2	`1d15fd8`	link	true	`/test e2e-aws-serial-techpreview-2of2`
ci/prow/e2e-aws-serial-1of2	`1d15fd8`	link	true	`/test e2e-aws-serial-1of2`
ci/prow/e2e-upgrade	`1d15fd8`	link	true	`/test e2e-upgrade`
ci/prow/e2e-aws-ovn-techpreview	`1d15fd8`	link	true	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-aws-ovn	`1d15fd8`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-aws-ovn-hypershift	`1d15fd8`	link	true	`/test e2e-aws-ovn-hypershift`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dasanind · 2026-08-26T14:08:18Z

/retest

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2026

openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 21, 2026

openshift-ci Bot requested review from everettraven and sayan-biswas August 21, 2026 14:54

openshift-merge-bot Bot added the pipeline-auto label Aug 21, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 24, 2026

dasanind mentioned this pull request Aug 24, 2026

OCPBUGS-105402: Remove EVPN feature gate references openshift/cluster-network-operator#3137

Open

Merge branch 'openshift:master' into OCPBUGS-105402

1d15fd8

dasanind force-pushed the OCPBUGS-105402 branch from 445982f to 1d15fd8 Compare August 25, 2026 15:27

Uh oh!

Conversation

dasanind commented Aug 21, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 21, 2026

Uh oh!

openshift-ci-robot commented Aug 21, 2026

Uh oh!

openshift-ci Bot commented Aug 21, 2026

Uh oh!

coderabbitai Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci Bot commented Aug 21, 2026

Uh oh!

dasanind commented Aug 21, 2026

Uh oh!

openshift-ci-robot commented Aug 21, 2026

Uh oh!

everettraven commented Aug 21, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 21, 2026

Uh oh!

dasanind commented Aug 24, 2026

Uh oh!

openshift-ci-robot commented Aug 24, 2026

Uh oh!

dasanind commented Aug 24, 2026

Uh oh!

dasanind commented Aug 24, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 25, 2026

Uh oh!

dasanind commented Aug 25, 2026

Uh oh!

dasanind commented Aug 25, 2026

Uh oh!

dasanind commented Aug 25, 2026

Uh oh!

dasanind commented Aug 25, 2026

Uh oh!

dasanind commented Aug 25, 2026

Uh oh!

openshift-ci Bot commented Aug 26, 2026

Uh oh!

dasanind commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Aug 21, 2026 •

edited

Loading