SRVOCF-1079: Fix Go and Python function build failures in CI - #179
Conversation
Update knative/func to 0.50.1-0.20260901181239-83fe1108e6a9 and bump k8s.io/* from 0.35.7 to 0.35.8. Also updates the broader knative ecosystem (eventing, serving, networking, pkg, client) and misc indirect deps (cert-manager, otel, gateway-api, grpc). Pin FuncCliVersion in the CI workflow generator to match the updated knative/func module version, giving us explicit control over the func CLI version installed in generated CI pipelines. Signed-off-by: Pedro Almeida <pealmeid@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@pmeida: This pull request references SRVOCF-1079 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
Sometimes, python deploys still fail at the pod level. We're digging into it to check if it is worth waiting for a fix. |
|
@pmeida: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Go and Python function builds were failing in CI because the generated workflow installed
funcCLIknative-v1.22.0- upstream had the default outdated. That version treats an HTTP 500 from the OCP internal registry as fatal duringfunc push, whereasknative-v1.23.0contains the upstream fix (knative/func#3885).knative.dev/funcmodule to a pseudo version that includes func cli overwrite possibility and the default updatedFuncCliVersion: knative-v1.23.0in the generated GitHub Actions workflow so it installs the fixed CLI version - enabled by fix: source func CLI version from build ldflags knative/func#4029config.FuncCLIVersionto make future updates explicit and discoverable; add an assertion in the scaffold test to catch version mismatches on future module bumpsManual tests were run across all runtimes (Go, Python, Node, Quarkus) to confirm the fix. In the future,
e2e testsusingactin the fake GitHub server will exercise function creation end-to-end across all runtimes, catching this classof issue automatically even when it originates upstream.
Checklist
docs/ARCHITECTURE.md(if there are relevant changes to our layered architecture)Fixes SRVOCF-1079