ROSAENG-61841: remove Konflux e2e pipelines, e2e image now built in Prow - #627
Conversation
|
@dustman9000: This pull request references ROSAENG-61841 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe pull-request and push Tekton Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes the Konflux pull-request and push e2e pipeline definitions as e2e image builds move to Prow. No concrete unresolved merge-readiness risk is established by the available evidence. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: Stable And Deterministic Test NamesExplanation PASS — Commit b0eb621 changes only two Tekton YAML files, both deleted. The patch contains no Ginkgo Full details: Test Structure And QualityExplanation PASS: The pull request changes only two Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request only deletes two Tekton PipelineRun YAML files. The diff adds no deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is therefore not applicable. Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only two Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS. The pull request changes only two Tekton PipelineRun YAML files and deletes them. The commit adds no Ginkgo e2e tests or test code, so the IPv6 and disconnected-network test compatibility check is not applicable. Full details: No-Weak-CryptoExplanation PASS. The commit only deletes two Tekton YAML PipelineRun files. The exact diff contains 99 deletions and no additions. The deleted files contain pipeline metadata, image parameters, and a Git authentication secret reference, but no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison logic. Therefore, the pull request does not introduce a weak-crypto condition. Full details: Container-PrivilegesExplanation PASS. The pull request only deletes two Tekton PipelineRun manifests. The deleted manifests contain no Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request only deletes two Tekton PipelineRun YAML files. It adds no logging code and introduces no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data in logs. The removed files contained pipeline metadata and a secret reference, not log statements. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@dustman9000: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, joshbranham The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
.tekton/managed-cluster-validating-webhooks-e2e-pull-request.yamland.tekton/managed-cluster-validating-webhooks-e2e-push.yamloperator-e2eimage is now built by the Prow ci-operator pipeline, not KonfluxJira: https://redhat.atlassian.net/browse/ROSAENG-61841
Summary by CodeRabbit