Skip to content

ROSAENG-61841: remove Konflux e2e pipelines, e2e image now built in Prow - #627

Merged
dustman9000 merged 1 commit into
openshift:masterfrom
dustman9000:rosaeng-61841-remove-e2e-tekton
Sep 3, 2026
Merged

ROSAENG-61841: remove Konflux e2e pipelines, e2e image now built in Prow#627
dustman9000 merged 1 commit into
openshift:masterfrom
dustman9000:rosaeng-61841-remove-e2e-tekton

Conversation

@dustman9000

@dustman9000 dustman9000 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes .tekton/managed-cluster-validating-webhooks-e2e-pull-request.yaml and .tekton/managed-cluster-validating-webhooks-e2e-push.yaml
  • The operator-e2e image is now built by the Prow ci-operator pipeline, not Konflux
  • Companion MRs: app-interface MR !205100 (SAPM wiring) and konflux-release-data MR !22293 (RPA cleanup)

Jira: https://redhat.atlassian.net/browse/ROSAENG-61841

Summary by CodeRabbit

  • Chores
    • Removed the pull-request validation pipeline configuration.
    • Removed the push-event validation pipeline configuration.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2026

Copy link
Copy Markdown

@dustman9000: This pull request references ROSAENG-61841 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • Removes .tekton/managed-cluster-validating-webhooks-e2e-pull-request.yaml and .tekton/managed-cluster-validating-webhooks-e2e-push.yaml
  • The operator-e2e image is now built by the Prow ci-operator pipeline, not Konflux
  • Companion MRs: app-interface MR !205100 (SAPM wiring) and konflux-release-data MR !22293 (RPA cleanup)

Jira: https://redhat.atlassian.net/browse/ROSAENG-61841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c34c5744-a18c-4fb2-bdb8-affedd0e6569

📥 Commits

Reviewing files that changed from the base of the PR and between c0d8291 and b0eb621.

📒 Files selected for processing (2)
  • .tekton/managed-cluster-validating-webhooks-e2e-pull-request.yaml
  • .tekton/managed-cluster-validating-webhooks-e2e-push.yaml
💤 Files with no reviewable changes (2)
  • .tekton/managed-cluster-validating-webhooks-e2e-pull-request.yaml
  • .tekton/managed-cluster-validating-webhooks-e2e-push.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The pull-request and push Tekton PipelineRun definitions were deleted from .tekton.

Changes

Cohort / File(s) Summary
Tekton PipelineRun removal
.tekton/managed-cluster-validating-webhooks-e2e-pull-request.yaml, .tekton/managed-cluster-validating-webhooks-e2e-push.yaml
Deletes the pull-request and push PipelineRun configurations, including triggers, parameters, workspaces, service accounts, and pipeline references.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b0eb6

This change removes the Konflux pull-request and push e2e pipeline definitions as e2e image builds move to Prow. No concrete unresolved merge-readiness risk is established by the available evidence.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the removal of the Konflux e2e pipelines and the move of e2e image builds to Prow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS — Commit b0eb621 changes only two Tekton YAML files, both deleted. The patch contains no Ginkgo It, Describe, Context, or When test titles. Therefore, the pull request introduces no unsta…
Test Structure And Quality ✅ Passed PASS: The pull request changes only two .tekton/*.yaml PipelineRun definitions, both deleted. The committed diff contains no Ginkgo or test-source changes, so it introduces no test responsibility, c…
Microshift Test Compatibility ✅ Passed PASS: The pull request only deletes two Tekton YAML PipelineRun definitions. The parent-to-HEAD diff contains no added Ginkgo tests or test code, so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only two .tekton PipelineRun YAML files and deletes them. The commit contains no added or modified Ginkgo tests, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request only deletes two Tekton PipelineRun YAML files. The diff adds no deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, toleratio…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only two .tekton PipelineRun manifests and deletes them. The diff contains no Go, e2e runner, or Dockerfile changes. The e2e runner and suite files are byte-for-byte u…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only two Tekton PipelineRun YAML files and deletes them. The commit adds no Ginkgo e2e tests or test code, so the IPv6 and disconnected-network test compatibility check …
No-Weak-Crypto ✅ Passed PASS. The commit only deletes two Tekton YAML PipelineRun files. The exact diff contains 99 deletions and no additions. The deleted files contain pipeline metadata, image parameters, and a Git authent…
Container-Privileges ✅ Passed PASS. The pull request only deletes two Tekton PipelineRun manifests. The deleted manifests contain no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `allowPrivilegeEscalatio…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request only deletes two Tekton PipelineRun YAML files. It adds no logging code and introduces no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data in …
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS — Commit b0eb621 changes only two Tekton YAML files, both deleted. The patch contains no Ginkgo It, Describe, Context, or When test titles. Therefore, the pull request introduces no unstable or overly specific test name.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only two .tekton/*.yaml PipelineRun definitions, both deleted. The committed diff contains no Ginkgo or test-source changes, so it introduces no test responsibility, cleanup, timeout, assertion-message, or test-pattern failure under this check.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request only deletes two Tekton PipelineRun YAML files. The diff adds no deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only two .tekton PipelineRun manifests and deletes them. The diff contains no Go, e2e runner, or Dockerfile changes. The e2e runner and suite files are byte-for-byte unchanged, so the pull request introduces no process-level stdout write or OTE stdout contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS. The pull request changes only two Tekton PipelineRun YAML files and deletes them. The commit adds no Ginkgo e2e tests or test code, so the IPv6 and disconnected-network test compatibility check is not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The commit only deletes two Tekton YAML PipelineRun files. The exact diff contains 99 deletions and no additions. The deleted files contain pipeline metadata, image parameters, and a Git authentication secret reference, but no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison logic. Therefore, the pull request does not introduce a weak-crypto condition.

Full details: Container-Privileges

Explanation

PASS. The pull request only deletes two Tekton PipelineRun manifests. The deleted manifests contain no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation: true settings. The diff adds no manifest lines, so it does not introduce a container-privilege violation.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request only deletes two Tekton PipelineRun YAML files. It adds no logging code and introduces no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data in logs. The removed files contained pipeline metadata and a secret reference, not log statements.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from ravitri and smarthall September 3, 2026 19:51
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2026
@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joshbranham

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026
@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dustman9000,joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustman9000
dustman9000 merged commit 6bdb21e into openshift:master Sep 3, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants