Conversation
Add the MicroShift 5.1 stream to the boot-measurement version table so source-build performance runs can proceed past version validation. Confirm six core non-storage pods and nine core pods overall against the installed 5.1 source build on the scratch VM. Leave existing streams and the readiness script unchanged. Signed-off-by: Sebastian Jug <seb@stianj.ug>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@sjug: This pull request references USHIFT-7526 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughChangesMicroShift version data
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The change adds the MicroShift 5.1 version mapping without identified impact to existing streams or readiness behavior. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sjug The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sjug: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Adds MicroShift 5.1 to the boot-measurement version table so source-build performance runs can proceed past version validation. The expected counts are six core non-storage pods and nine core pods overall, confirmed on the scratch VM rather than inferred from 5.0.
Tracks USHIFT-7526. Addresses the missing-version blocker encountered while qualifying openshift/release#83408.
Validation
Reproduced the missing-version failure with the original table, then successfully ran the real shared boot tasks with the updated entry. Independently confirmed all nine core pods Ready on source revision
ec2583ab13162c2701615a493af0fed1c5deb463. Version lookups for 4.22 and 5.0 remain unchanged; syntax and diff checks pass.Validation was limited to the version lookup and focused boot path, not the full deployment playbook. The existing readiness script can count optional components toward its thresholds, so core readiness was checked separately. This PR does not change that behavior.
Summary by CodeRabbit