Skip to content

USHIFT-7526: Ansible: support MicroShift 5.1 boot measurements - #7386

Open
sjug wants to merge 1 commit into
openshift:mainfrom
sjug:ushift-7526-51-pod-counts
Open

sjug wants to merge 1 commit into
openshift:mainfrom
sjug:ushift-7526-51-pod-counts

Conversation

@sjug

@sjug sjug commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds MicroShift 5.1 to the boot-measurement version table so source-build performance runs can proceed past version validation. The expected counts are six core non-storage pods and nine core pods overall, confirmed on the scratch VM rather than inferred from 5.0.

Tracks USHIFT-7526. Addresses the missing-version blocker encountered while qualifying openshift/release#83408.

Validation

Reproduced the missing-version failure with the original table, then successfully ran the real shared boot tasks with the updated entry. Independently confirmed all nine core pods Ready on source revision ec2583ab13162c2701615a493af0fed1c5deb463. Version lookups for 4.22 and 5.0 remain unchanged; syntax and diff checks pass.

Validation was limited to the version lookup and focused boot path, not the full deployment playbook. The existing readiness script can count optional components toward its thresholds, so core readiness was checked separately. This PR does not change that behavior.

Summary by CodeRabbit

  • New Features
    • Added version 5.1 support with updated expected and total pod counts.

Add the MicroShift 5.1 stream to the boot-measurement version table so
source-build performance runs can proceed past version validation.

Confirm six core non-storage pods and nine core pods overall against the
installed 5.1 source build on the scratch VM. Leave existing streams and
the readiness script unchanged.

Signed-off-by: Sebastian Jug <seb@stianj.ug>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 16, 2026

Copy link
Copy Markdown

@sjug: This pull request references USHIFT-7526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

Adds MicroShift 5.1 to the boot-measurement version table so source-build performance runs can proceed past version validation. The expected counts are six core non-storage pods and nine core pods overall, confirmed on the scratch VM rather than inferred from 5.0.

Tracks USHIFT-7526. Addresses the missing-version blocker encountered while qualifying openshift/release#83408.

Validation

Reproduced the missing-version failure with the original table, then successfully ran the real shared boot tasks with the updated entry. Independently confirmed all nine core pods Ready on source revision ec2583ab13162c2701615a493af0fed1c5deb463. Version lookups for 4.22 and 5.0 remain unchanged; syntax and diff checks pass.

Validation was limited to the version lookup and focused boot path, not the full deployment playbook. The existing readiness script can count optional components toward its thresholds, so core readiness was checked separately. This PR does not change that behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: c67b84b8-dfd4-4d07-863d-66e70ef0797a

📥 Commits

Reviewing files that changed from the base of the PR and between 7295d8c and 012e3ae.

📒 Files selected for processing (1)
  • ansible/vars/microshift_versions.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

Changes

MicroShift version data

Layer / File(s) Summary
Add 5.1 pod counts
ansible/vars/microshift_versions.yml
Adds version 5.1 with expected_pods: 6 and all_pods: 9.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 012e3

The change adds the MicroShift 5.1 version mapping without identified impact to existing streams or readiness behavior.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Ansible change and the added MicroShift 5.1 boot-measurement support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The authoritative diff changes only ansible/vars/microshift_versions.yml. It adds static YAML values for version 5.1 (expected_pods: 6 and all_pods: 9). It does not add or modify Ginkgo …
Test Structure And Quality ✅ Passed PASS: The pull request changes only ansible/vars/microshift_versions.yml, adding the 5.1 pod-count mapping. It does not add or modify Ginkgo test code, test setup, cleanup, waits, or assertions. T…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only ansible/vars/microshift_versions.yml. It adds MicroShift version data and adds no Ginkgo e2e tests or test declarations. The custom check is therefore not applica…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only ansible/vars/microshift_versions.yml and adds MicroShift 5.1 pod-count data. It adds no Ginkgo tests or test code, so it introduces no multi-node or HA assumption…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only ansible/vars/microshift_versions.yml. It adds microshift_versions["5.1"] with pod-count values. It does not add or modify deployment manifests, operators, contr…
Ote Binary Stdout Contract ✅ Passed PASS: The authoritative pull-request diff changes only ansible/vars/microshift_versions.yml. It adds data values for MicroShift 5.1; it adds no executable code, suite setup, initializer, logging c…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only ansible/vars/microshift_versions.yml, adding the MicroShift 5.1 pod-count entry. It adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements. The c…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only ansible/vars/microshift_versions.yml and adds the data-only 5.1 pod-count entry. The added lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cry…
Container-Privileges ✅ Passed The pull request changes only ansible/vars/microshift_versions.yml by adding 5.1 pod-count values. The patch adds no container or Kubernetes security settings, including privileged: true, `hostP…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only ansible/vars/microshift_versions.yml. It adds the 5.1 key with numeric values expected_pods: 6 and all_pods: 9. No passwords, tokens, API keys, PII, hostnames, or…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from agullon and copejon September 16, 2026 19:52
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjug
Once this PR has been reviewed and has the lgtm label, please assign pacevedom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@sjug: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants