[OSDOCS-84105]: Adding details to load balancer docs for HCP on OpenShift Virt - #119606
Conversation
openshift-ci
Bot
added
the
size/XS
palonsoro
left a comment
palonsoro
left a comment
There was a problem hiding this comment.
Thanks for opening the PR.
Here go some change requests.
| [role="_abstract"] | ||
| Set up the load balancer service that routes ingress traffic to the KubeVirt VMs and assigns a wildcard DNS entry to the load balancer IP address. | ||
|
|
||
| When you create a `LoadBalancer` service on an {VirtProductName} hosted cluster, the service is made available through the management cluster by using the same technology that the management cluster has configured for `LoadBalancer` services, such as MetalLB. |
There was a problem hiding this comment.
While strictly speaking this is true, it can lead to misunderstanding. Literally reading it gives the impression that hosted cluster just "copies" or "reuses" management cluster's load balancer technology, which is wrong.
What actually happens in detail is:
- A load balancer service is created in the hosted cluster, let's name it an "inner load balancer service", which gets exposed on the hosted cluster VMs via some node ports.
- The cloud provider and the hypershift-operator work together to create a "mirror" or "outer" load balancer service on the management cluster that exposes the node ports of the hosted cluster's "inner" load balancer service through whatever technology the management cluster uses for load balancer services.
The explanation above is likely too long to be just included in the docs as is. However, maybe we should go with something similar to:
| When you create a `LoadBalancer` service on an {VirtProductName} hosted cluster, the service is made available through the management cluster by using the same technology that the management cluster has configured for `LoadBalancer` services, such as MetalLB. | |
| When you create a `LoadBalancer` service on an {VirtProductName} hosted cluster, a mirror `LoadBalancer` service is automatically created and configured on the management cluster to expose it. Because of this, the hosted cluster `LoadBalancer` services end up exposed through the same technology that the management cluster has configured for its own `LoadBalancer` services, such as MetalLB. |
Of course, your writing will be much better than mine.
There was a problem hiding this comment.
@palonsoro Thanks for the clarification! I updated the wording to include the details that you mentioned.
31c8a4e to
761e5e9
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
palonsoro
left a comment
palonsoro
left a comment
There was a problem hiding this comment.
It looks perfect, thanks!
|
/lgtm |
|
/lgtm |
|
/cherrypick enterprise-5.0 |
|
@lahinson: new pull request created: #119673 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #119674 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #119675 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #119676 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #119677 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #119678 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Version(s): 4.18+
Issue: https://redhat.atlassian.net/browse/OCPBUGS-84105
Link to docs preview: https://119606--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-virt.html#hcp-virt-load-balancer_hcp-deploy-virt
QE review:
Additional information: