Skip to content

[reproducer] Add remove top-level keys from a YAML file - #4086

Merged
bshewale merged 1 commit into
openstack-k8s-operators:mainfrom
evallesp:deep-merge-strip-keys
Aug 11, 2026
Merged

[reproducer] Add remove top-level keys from a YAML file#4086
bshewale merged 1 commit into
openstack-k8s-operators:mainfrom
evallesp:deep-merge-strip-keys

Conversation

@evallesp

@evallesp evallesp commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Plugin for removing top-level key that appears in a provided
key-source yamls files.

Used at overwrite_zuul_vars file for removing variables
added at: exclude_discovered_files as in premetal path
these variables were already loaded in previous premetal step.

Signed-off-by: Enrique Vallespi Gil evallesp@redhat.com

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nemarjan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 31, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/90c5971c1b994d758108f28e9839c2fe

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 35m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 52m 02s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 10m 04s
❌ cifmw-pod-pre-commit FAILURE in 9m 49s
✔️ cifmw-molecule-reproducer SUCCESS in 13m 55s

@evallesp
evallesp force-pushed the deep-merge-strip-keys branch from 033210e to 2a37585 Compare August 7, 2026 08:51
@evallesp evallesp changed the title [DNM][Test] Add strip keys capabilitie to deep_merge Add remove top-level keys from a YAML file Aug 7, 2026
@evallesp
evallesp force-pushed the deep-merge-strip-keys branch from 2a37585 to 2f58769 Compare August 7, 2026 08:52
@evallesp evallesp changed the title Add remove top-level keys from a YAML file [reproducer] Add remove top-level keys from a YAML file Aug 7, 2026
@evallesp
evallesp force-pushed the deep-merge-strip-keys branch from 2f58769 to a676c22 Compare August 7, 2026 09:44
Valkyrie00
Valkyrie00 reviewed Aug 11, 2026
View reviewed changes
Comment thread plugins/modules/strip_dict_keys.py Outdated
@evallesp
[reproducer] Add remove top-level keys from a YAML file
5a92052 
Plugin for removing top-level key that appears in a provided
key-source yamls files.

Used at overwrite_zuul_vars file for removing variables
added at: exclude_discovered_files as in premetal path
these variables were already loaded in previous premetal step.

Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
@evallesp
evallesp force-pushed the deep-merge-strip-keys branch from a676c22 to 5a92052 Compare August 11, 2026 09:16
Valkyrie00
Valkyrie00 approved these changes Aug 11, 2026
View reviewed changes

@Valkyrie00 Valkyrie00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Aug 11, 2026
@bshewale
bshewale merged commit 441fe17 into openstack-k8s-operators:main Aug 11, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valkyrie00 Valkyrie00 Valkyrie00 approved these changes
@bshewale bshewale bshewale approved these changes

Assignees

@Valkyrie00 Valkyrie00

Labels

lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evallesp @Valkyrie00 @bshewale