Skip to content

Fix missing is succeeded guard on Wait for NHC CR task - #4093

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
antonioromito:fix-snr-nhc-wait-condition
Aug 11, 2026
Merged

Fix missing is succeeded guard on Wait for NHC CR task#4093
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
antonioromito:fix-snr-nhc-wait-condition

Conversation

@antonioromito

Copy link
Copy Markdown
Contributor
  • The previous fix (f9b046b) added is succeeded guards to three of the four NodeHealthCheck tasks but missed the "Wait for Node Health Check CR to be created" task
  • Without this guard, a transient API failure on that task causes an unhandled error instead of being skipped gracefully — inconsistent with the other three tasks in the same flow

The previous fix (f9b046b) added `is succeeded` guards to three of the
four NodeHealthCheck tasks but missed the "Wait for Node Health Check CR
to be created" task, leaving it inconsistent. A transient API failure
there would cause an unhandled error instead of being skipped gracefully.

Signed-off-by: Antonio Romito <aromito@redhat.com>
@antonioromito
antonioromito force-pushed the fix-snr-nhc-wait-condition branch from 7b20741 to 3c92633 Compare August 7, 2026 18:11
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/9569483ed13244bf8c1443d89f558eea

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 58s
podified-multinode-edpm-deployment-crc POST_FAILURE in 22m 04s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 35s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 24m 17s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 16s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 2h 17m 48s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 43m 10s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 23s
✔️ cifmw-molecule-cifmw_snr_nhc SUCCESS in 5m 17s

@antonioromito

Copy link
Copy Markdown
Contributor Author

recheck

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michburk michburk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michburk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit fc57e08 into openstack-k8s-operators:main Aug 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants