Add aodh containers - #72
Conversation
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
Thanks a lot for consolidating into one single container, that's great!
About naming, this will be producing openstack-aodh which didn't exist in tcib. @yazug was recommending to reuse an existing container name as that ease some tasks in the e2e workflow. Existing names are openstack-aodh-[base,api,evaluator,notifier,listener] . In watcher we consolidated in openstack-watcher-base although there is no rule. I'm not sure how much flexibility exist in adding new names.
Other comments inline.
| ARG PIP_NO_BINARY="" | ||
| ENV PIP_NO_BINARY=${PIP_NO_BINARY} | ||
| # required to build rpds-py from source | ||
| ENV MATURIN_NO_INSTALL_RUST=true | ||
|
|
There was a problem hiding this comment.
Needs https://github.com/openstack-k8s-operators/s2i-openstack-containers/blob/main/containers/watcher/watcher-base/builddeps.txt#L13-L16 to build deps from source case.
Assisted-By: Cladue Opus 4.6
It is an optional dep that is not included by default.
6cb4040 to
d34dda5
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d50de83
into
openstack-k8s-operators:main
3 participants
No description provided.