Add nova-api container image - #74
Conversation
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Containerfile mostly looks good, but see my inline comments.
e2841fb to
10d571f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8c89556 to
0784fd7
Compare
0784fd7 to
72d3afc
Compare
| - qemu-kvm-block-rbd | ||
| - qemu-kvm-core | ||
| - qemu-kvm-device-display-virtio-gpu |
There was a problem hiding this comment.
so nova-compute need qemu-img
and we need rbd for qemu-img
but we do not need qemu-kvm-device-display-virtio-gpu
and im not sure we need qemu-kvm-core
the vms that nova manages are create by libvirt outside of the nova-compute container
also nova should likely be 2 images like cybrog
one for the podifed services on openshshift and one for the edpm node contianer as that need a lot of deps that the rest do not
| - libvirt-daemon-driver-nodedev | ||
| - libvirt-daemon-driver-nwfilter | ||
| - libvirt-daemon-driver-qemu | ||
| - libvirt-daemon-driver-secret | ||
| - libvirt-daemon-driver-storage-core |
There was a problem hiding this comment.
these are not needed
the libvirt deamo is not used in the nova contaienrs not even nova-compute
its installed on teh host
we jsut need the libvirt lib to build the python3-libvirt package
| - ceph-common | ||
| - device-mapper-multipath | ||
| - e2fsprogs |
There was a problem hiding this comment.
these are only needed on the edpm node
| - gcc-c++ | ||
| - git-core | ||
| - httpd | ||
| - iscsi-initiator-utils |
There was a problem hiding this comment.
- iscsi-initiator-utils is edpm only as is libosinfo below
| - nvme-cli | ||
| - openssh-clients | ||
| - openssl-devel | ||
| - openvswitch |
There was a problem hiding this comment.
this is edpm node only
techinally we only require the ovs lib
https://github.com/openstack-k8s-operators/tcib/blob/main/container-images/tcib/base/os/nova-base/nova-compute/nova-compute.yaml#L28
but that stop being its own package after rhel 8
| - x86_64 | ||
| - aarch64 | ||
|
|
||
| packages: |
There was a problem hiding this comment.
so this file is ment to be generated
form bindeps.txt and builddeps.txt
but the content of it does nto look corect to me.
72d3afc to
b3cd845
Compare
Nova API container serving both osapi_compute (port 8774) and metadata (port 8775) APIs via Apache/mod_wsgi. Multi-stage Containerfile built from source with cryptography pinned to 49.0.0 (RPM version) and pyOpenSSL 26.4.0 for compatibility. Includes WSGI wrapper scripts for both APIs (authored for this repo, as upstream nova removed its wsgi scripts). Also includes project-level lock files and sources shared by future nova services. Signed-off-by: Matěj Mudra <mmudra@redhat.com>
b3cd845 to
a1f255d
Compare
4 participants
Nova API container serving both osapi_compute (port 8774) and metadata
(port 8775) APIs via Apache/mod_wsgi. Multi-stage Containerfile built
from source with cryptography pinned to 49.0.0 (RPM version) and
pyOpenSSL 26.4.0 for compatibility.
Includes WSGI wrapper scripts for both APIs (authored for this repo,
as upstream nova removed its wsgi scripts). Also includes project-level
lock files and sources shared by future nova services.