Skip to content

Add slf4j marker to span logs - #334

Open
sokomishalov wants to merge 1 commit into
opentracing-contrib:masterfrom
sokomishalov:master
Open

Add slf4j marker to span logs#334
sokomishalov wants to merge 1 commit into
opentracing-contrib:masterfrom
sokomishalov:master

Conversation

@sokomishalov

@sokomishalov sokomishalov commented Dec 13, 2021

Copy link
Copy Markdown

Summary by CodeRabbit

  • Enhancements
    • Span logs now include the associated logging marker name when one is provided, improving log traceability.

@lucacome

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b1ff8ac-1c10-413d-af1e-e9fd248dcb45

📥 Commits

Reviewing files that changed from the base of the PR and between 924f727 and 897d3ae.

📒 Files selected for processing (1)
  • instrument-starters/opentracing-spring-cloud-core/src/main/java/io/opentracing/contrib/spring/cloud/log/SpanLogsAppender.java

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

Changes

Span log marker enrichment

Layer / File(s) Summary
Add marker names to span logs
instrument-starters/opentracing-spring-cloud-core/src/main/java/io/opentracing/contrib/spring/cloud/log/SpanLogsAppender.java
SpanLogsAppender.append adds the logging marker name to the span log map under marker when the event has a non-null marker.

Suggested reviewers: lucacome

Merge Risk: ⚪ Minimal · up to 897d3

This is a small, localized change to span logging behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the SLF4J marker to span logs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants