Improve OMNI input validation - #4541
Open
michalkulakowski wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update the test to expect 16 frames and 64 bytes, or use a 16 kHz input.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves OMNI WAV input validation by enforcing decoded-size limits, including when resampling is disabled.
Changes:
- Adds overflow and maximum decoded-size checks.
- Adds no-resampling WAV boundary tests.
File summaries
| File | Summary |
|---|---|
src/audio/audio_utils.cpp |
Adds decoded buffer size validation before allocation. |
src/test/audio/audio_utils_test.cpp |
Adds no-resampling size-limit tests; one expectation currently fails. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+175
to
+179
| size_t expectedDecodedSize = static_cast<size_t>(8 * sizeof(float)); | ||
| SetEnvironmentVar("OVMS_AUDIO_MAX_FILE_SIZE_BYTES", std::to_string(expectedDecodedSize)); | ||
| std::vector<float> decoded; | ||
| EXPECT_NO_THROW({ decoded = readWithoutResample(view, "wav"); }); | ||
| EXPECT_EQ(decoded.size(), 8u); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``