feat: Add propagation of openFullTabView parameter to Opera tools - #40
Merged
Conversation
| /** | ||
| * Reject `--open-fulltab-view` in headless mode. Activating a foreground tab | ||
| * in a headless window is nonsensical; the extension cannot distinguish headed | ||
| * from headless, so the CLI owns this validation. Mirrors the contract in |
Contributor
There was a problem hiding this comment.
The doc comment in requireHeadedForFullTabView references docs/cdp-fulltab-view-contract.md §4, but that file isnt in the repo (checked, no refs anywhere). Either add it or drop the reference before merge.
|
|
||
| async function handleInvokeDo(args: string[]): Promise<string> { | ||
| const prompt = args.join(" "); | ||
| const openFullTabView = args.includes("--open-fulltab-view"); |
Contributor
There was a problem hiding this comment.
nit: invoke-do parses the flag manually (includes + filter) while the other three go through a parser. Minor, but itll silently strip a literal --open-fulltab-view that a user actually types in a prompt. Could reuse parseChatOrMakeArgs for consistency.
Contributor
There was a problem hiding this comment.
fixed, now uses parseChatOrMakeArgs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.