색상 어셋와 l10n 파일을 시뮬레이터에서 동작하도록 정리한다 - #857
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
디자인 이미지와
design.md를 기준으로 공통 색상을 정리하고, 로컬라이제이션 원본을 하나로 유지하면서 Presentation Preview에서도 번역 문자열을 표시하도록 개선📝 작업 내용
📌 요약
Localizable.xcstrings원본을PresentationShared로 통합🔍 상세
review,reviewContainer추가 및ColorAsset반영PresentationShared가 동일한Localizable.xcstrings파일을 각각 번들 리소스로 포함하도록 Tuist 설정 변경PresentationResources.bundle적용SystemTheme.localizedName(in:)추가 및 기존 기본 번들 조회 방식 유지