Skip to content

Keep the binaries and promote jobs running when the corpus gate is skipped #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orlowdev merged 1 commit into from
Aug 29, 2026
Merged

Keep the binaries and promote jobs running when the corpus gate is skipped #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,12 @@ jobs:

binaries:
needs: version
if: needs.version.outputs.created == 'true'
# `!cancelled()` is load-bearing: `version` runs past a SKIPPED `corpus` (nightly) via its own
# status-function `if`, but without a status function here GitHub would propagate that skip down the
# `needs` chain and skip `binaries` regardless of `created` — so a nightly release got no binaries.
# With it, the skip no longer propagates and the real gate (`version` succeeded, a release was cut)
# decides. `created` is empty when `version` itself was skipped (rc/latest/stable with a red corpus).
if: ${{ !cancelled() && needs.version.result == 'success' && needs.version.outputs.created == 'true' }}
uses: ./.github/workflows/build-binaries.yml
permissions:
contents: write
Expand All @@ -150,7 +155,9 @@ jobs:
# The bare `<ring>` tags don't collide with the `<version>-<ring>` tags `versioning` matches on.
promote:
needs: [version, binaries]
if: needs.version.outputs.created == 'true'
# Same status-function requirement as `binaries`: only mirror the rolling ring release when the
# binaries actually built (`binaries` succeeded — which already implies a release was cut).
if: ${{ !cancelled() && needs.binaries.result == 'success' }}
runs-on: ubuntu-24.04
permissions:
contents: write
Expand Down
Loading