feat: add back gesture to go up one folder - #4943
Conversation
|
@alexknop thanks for the contribution!! we'll check it asap. As first input, please check the calens file (lacks of endline and description). Get some examples from https://github.com/owncloud/android/tree/master/changelog/ |
|
Thanks for taking care!!, i will give you an extra tips:
Title: Description: What do you think? Summarizing, you can resolve the PR with just two commits: one for the fix, and another one for the calens entry. By fixing these two small issues, we'll move first to code review and then, to QA. Closer to the final! 🚀 PD: any question or whatever you need, don't hesitate to ping us!! |
9990790 to
9b9afa7
Compare
|
@jesmrec done! |
cc80170 to
055aa6f
Compare
There was a problem hiding this comment.
Code is OK now! Good job @alexknop! 💯
One note about commits: all commits must be GPG/PGP signed and include a Signed-off-by line. Use the command: git commit -s -S -m "..." for that. Unfortunately, we won't be able to merge the PR until all commits are properly signed.
Thanks for your effort! 🙌🏻 Let us know if you have any doubts and we will help you!
Signed-off-by: alex <knopalex@msu.edu>
Signed-off-by: alex <knopalex@msu.edu>
055aa6f to
e313a5b
Compare
|
@joragua Done! |
Related Issues
No logged Issue.
Enhancement: Allow Back Gesture in Android to go back a folder instead of closing the application. If on the root folder, it will exit the application.
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA