Skip to content

refactor: remove ID count from offsets - #478

Merged
cheb0 merged 3 commits into
ozontech:mainfrom
spacer07:409-remove-ids-count-from-offsets
Aug 24, 2026
Merged

refactor: remove ID count from offsets#478
cheb0 merged 3 commits into
ozontech:mainfrom
spacer07:409-remove-ids-count-from-offsets

Conversation

@spacer07

Copy link
Copy Markdown
Contributor

Description

This completes the binary format cleanup started in #410. It:

  • bumps the fraction binary data version to V6;
  • stops writing the legacy ID count placeholder to the offsets section;
  • keeps V0–V5 fractions readable by skipping the legacy field for old versions;

Fixes #409


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.29%. Comparing base (a73114c) to head (ee4ca9c).

Files with missing lines Patch % Lines
frac/sealed_loader.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   71.33%   71.29%   -0.04%     
==========================================
  Files         233      233              
  Lines       18999    18998       -1     
==========================================
- Hits        13552    13545       -7     
- Misses       4419     4427       +8     
+ Partials     1028     1026       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkharms dkharms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cheb0 can you take a look as well, please?

LGTM :shipit:
Thank you for contribution!

@cheb0

cheb0 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

@dkharms Looks good to me. We will have a version bump in 0.77, attached to the corresponding milestone

@cheb0
cheb0 self-requested a review July 31, 2026 06:00
@cheb0 cheb0 added this to the v0.77.0 milestone Jul 31, 2026
@cheb0
cheb0 merged commit 7070cbb into ozontech:main Aug 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not store count of ids in offsets section

4 participants