Skip to content

Do not overwrite the logger config on app.run - #392

Closed
embeddedc wants to merge 1 commit into
pallets:mainfrom
embeddedc:main
Closed

Do not overwrite the logger config on app.run#392
embeddedc wants to merge 1 commit into
pallets:mainfrom
embeddedc:main

Conversation

@embeddedc

Copy link
Copy Markdown

Do not overwrite the logHandler on app.run().
Instead propagate it to hypercorn, so

logHandler = RotatingFileHandler(...)
app.logger.addHandler(logHandler)
app.run(...)

works as expected...

@pgjones

pgjones commented Aug 7, 2026

Copy link
Copy Markdown
Member

Thank you, I've done so slightly differently in e506aec

@pgjones pgjones closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants