fix: approval and Woke follow-ups from the upstream sync review - #171
Merged
Conversation
A client sending the new acceptAlways decision to Hermes fell through the decision mapping's default and silently rejected the request. It now selects the allow_always option like acceptForSession does. Unreachable today (only Codex offers the option) but the decision union is provider-agnostic. Implemented by Claude Fable 5 via Claude Code.
The sidebar Woke pill and the chat wake banner suppressed themselves whenever the thread's change request would auto-settle it, ignoring the fork's auto-settle master gate. With the gate off the thread never settles, so the wake signal must stay visible. Both sites now apply the suppression only while autoSettleEnabled is true. Implemented by Claude Fable 5 via Claude Code.
Review follow-up: the Woke suppression also ignored the explicit keep-active pin and servers without the threadSettlement capability — both leave the thread active, so the wake signal must show. The predicate now lives in client-runtime as changeRequestMutesWakeSignal with tests, used by both the sidebar pill and the chat banner, and the two stale settled-tail comments were corrected. Implemented by Claude Fable 5 via Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small defects surfaced by the post-sync merge review, unrelated to the merge itself.
Hermes approvals. The
acceptAlwaysdecision (added upstream for Codex in pingdotgg#8058) fell through Hermes's decision mapping to a silentreject_once. It now maps toallow_always, with a unit test on the exported mapping. Unreachable today since only Codex offers the option, but the decision union is provider-agnostic.Woke indicator gating. The sidebar Woke pill and the chat wake banner suppressed themselves whenever a change request would auto-settle the thread, without checking the fork's auto-settle master gate. With the gate off the thread never settles, so the wake signal was lost. Both sites now suppress only while
threadAutoSettleEnabledis on. Mobile has no change-request suppression on its wake signal, so nothing to change there.Checks:
vp check,vp run typecheck, and the focused Hermes adapter suite (25 tests) pass.Implemented by Claude Fable 5 via Claude Code.