Fix connection labels and bus wire widths in SVG export - #340
Merged
Merged
Conversation
milanofthe
force-pushed
the
fix/svg-export-connection-labels
branch
from
September 19, 2026 08:11
739a19a to
2cdb7db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloned inline SVG only kept fill, stroke and opacity, so everything a stylesheet set was dropped from the export. Connection labels lost their font, size,
text-anchor,dominant-baselineandpaint-order(16px serif, anchored bottom left, halo painted over the glyphs), and bus wires lost their extra stroke width, so they looked like ordinary wires.Updated dom2svg bundle (milanofthe/dom2svg#2):
<text>is outlined to paths like HTML text, with the halo split into two stacked paths so PDF export keeps the paint orderVerified headlessly on a model with horizontal, vertical and bus labels: the export now matches the canvas.