Skip to content

chore(DualListSelector): Include OUIAProps for DualListSelector - #12597

Open
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:dual-list-selector-ouia
Open

chore(DualListSelector): Include OUIAProps for DualListSelector#12597
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:dual-list-selector-ouia

Conversation

@mshriver

@mshriver mshriver commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Add OUIA attribute support to DualListSelector for better test automation.

What: Closes #12596

Summary by CodeRabbit

  • New Features

    • Added Open UI Automation support to the Dual List Selector, including configurable component IDs and safety attributes.
    • The component now defaults to a safe automation setting when unspecified.
  • Documentation

    • Updated the Open UI Automation developer guide to include the Dual List Selector.

Add OUIA attribute support to DualListSelector for better test automation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: da35e033-80b1-461b-937d-e7141d49a844

📥 Commits

Reviewing files that changed from the base of the PR and between c4086a0 and dcde48d.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/DualListSelector/__tests__/__snapshots__/DualListSelector.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • packages/react-core/src/components/DualListSelector/DualListSelector.tsx
  • packages/react-core/src/components/DualListSelector/__tests__/DualListSelector.test.tsx
  • packages/react-core/src/helpers/OUIA/OUIA.md

Walkthrough

DualListSelector now supports OUIA props, renders corresponding data-ouia-* attributes, and defaults ouiaSafe to true. Tests cover the new attributes, and the OUIA guide lists the component.

Changes

DualListSelector OUIA integration

Layer / File(s) Summary
OUIA contract and root wiring
packages/react-core/src/components/DualListSelector/DualListSelector.tsx
DualListSelectorProps extends OUIAProps; useOUIAProps generates attributes using ouiaId and ouiaSafe, which are spread onto the root element.
OUIA validation and documentation
packages/react-core/src/components/DualListSelector/__tests__/DualListSelector.test.tsx, packages/react-core/src/helpers/OUIA/OUIA.md
Tests cover OUIA IDs, component type, safe defaults, and overrides; the OUIA guide lists DualListSelector.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • patternfly/patternfly-react#12594 — Adds OUIA support to another PatternFly React component.

Possibly related PRs

Suggested reviewers: rebeccaalpert, thatblindgeye

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding OUIAProps support to DualListSelector.
Linked Issues check ✅ Passed The code adds OUIA prop support, updates tests, and documents DualListSelector as requested in issue #12596.
Out of Scope Changes check ✅ Passed The changes stay focused on DualListSelector OUIA support, with only matching test and documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DualListSelector missing OUIA Support

1 participant