PRE-3603: Overload scalapay min/max amounts from API - #317
Open
adumont-payplug wants to merge 1 commit into
Open
PRE-3603: Overload scalapay min/max amounts from API#317adumont-payplug wants to merge 1 commit into
adumont-payplug wants to merge 1 commit into
Conversation
hdelaforce-payplug
left a comment
Contributor
There was a problem hiding this comment.
Automated review pass — 7 findings, most severe first. #1 is the one I'd block merge on: it's a config the admin form actively allows the merchant to save, and it silently disables Scalapay at checkout with zero diagnostic.
adumont-payplug
force-pushed
the
feature/PRE-3603_overload_min_max_scalapay
branch
2 times, most recently
from
September 3, 2026 09:19
b3e80fc to
c1d700f
Compare
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
adumont-payplug
force-pushed
the
feature/PRE-3603_overload_min_max_scalapay
branch
3 times, most recently
from
September 3, 2026 12:35
6919a97 to
85ed560
Compare
adumont-payplug
force-pushed
the
feature/PRE-3603_overload_min_max_scalapay
branch
from
September 3, 2026 12:55
85ed560 to
d8dcc57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scalapay currently shows at checkout for any cart amount within the limits reported by the PayPlug API, with no way for the merchant to tighten that range. This adds merchant-configurable min/max amount limits for Scalapay, mirroring the existing amount-filtering mechanism already used for the other PPRO gateways.
min_amount,max_amount) on the Scalapay gateway admin config, rendered asMoneyType(EUR) inputs. Left blank, they fall back to whatever the PayPlug API reports for the account.SupportedMethodsProvidernow applies the merchant's configured bounds (when set) instead of the raw API bounds when filtering Scalapay at checkout.IsScalapayAmountRangeValid) rejects configs where min > max, or where either value falls outside the live API-reported range — the merchant can only narrow the range, never widen it beyond what PayPlug authorizes.Motivation: Merchants want to control which cart sizes see Scalapay as a payment option (UX and fee control), similar to existing carve-outs for other financing/BNPL methods.
Related issue(s): Closes [PRE-3603](https://payplug-prod.atlassian.net/browse/PRE-3603)
Type of Change
Checklist
Code Quality
Testing
SupportedMethodsProviderTest,PaymentMethodValidatorTest, newScalapayGatewayConfigurationTypeExtensionTest, newIsScalapayAmountRangeValidValidatorTest)Security & Ops