Avoid stuck disconnect - #2197
Merged
Merged
Conversation
With TCP backpressure (server ACKs not arriving, send window full) the sender blocks in a java.io socket write, which ignores coroutine cancellation. disconnect() stopped the sender first (BaseSender.stop -> job.cancelAndJoin) and closed the socket only afterwards, so the join waited until the network recovered or TCP gave up. A reConnect hung for the whole time. Try a cooperative stop first (keeps the graceful close in the normal case) and, if the sender does not stop within 1 s, close the socket to unblock the write and stop again. RTSP over TCP (interleaved) writes to the same socket and has the same issue. SRT/UDP are not affected (UDP sends do not block on ACKs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.