Skip to content

Should the Announcer and UtteranceQueue both have an enabledProperty? #62

Description

@jessegreenberg

In #58 @zepumph said

Basically here are the control Properties that we have to keep track of:
UtteranceQueue.muted
UtteranceQueue.enabledProperty
SpeechSynthesisAnnouncer.enabledProperty
SpeechSynthesisAnnouncer.canSpeakProperty
With joist (thus our sims) kinda taking its pick as to what to set during different things, it is really hard for me to see the full picture, and thus what could be the best and simplest implementation. It is a work in progress, and one that relates to our conversation from a Friday past about creating a preferences model. Do you feel this tension, or am I overreacting? (those are your only two options. . . . )

I said

I did not feel the tension but see it now that you mention it. I don't think this relates to to canSpeakProperty (A private DerivedProperty) but I see it as confusing that we have an enabledProperty on both the UtteranceQueue and the Announcer. I could see us making the enabledProperty of the Announcer utterance-queueu internal.

It seems to me that all should go through the utteranceQueue. If the Announcer is disabled, that should be utterance-queue internal.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions