Make test backend ownership and conditional writes atomic - #29
Open
jeregrine wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The consistency-probe backend checks ETS before inserting or deleting. Concurrent claims can both succeed, and conditional writes/deletes can consume the same ETag more than once. This gives concurrency regressions a storage model that violates the backend contract.
Fix
Use atomic ETS insert-new, select-replace, select-delete, and take operations. Keep fault overrides and call recording intact. Treat stored values as literal match-spec data.
Add focused contract cases for contended creation, writes sharing a token, write/delete races, and stale tokens after deletion and replacement.
Supporting information
This changes only the test backend. Production adapters and their consistency semantics are unchanged.