Make lifecycle tests meaningful and isolate test storage - #34
Open
jeregrine wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several lifecycle scenarios can pass without actually recovering a server: they inspect unchanged metadata, use non-restartable fixtures, or make assertions against unrelated objects. The discovery waiter consumes a timeout rather than observing completion.
Every invocation also contacts LocalStack and clears a shared bucket, even when the selected tests need no storage. Concurrent runs can erase each other's state or collide on EKV directories and node names.
Fix
Supporting information
Only tests, support code, and documentation change; production behavior is unchanged.
The default selection excludes LocalStack, EKV, credentialed integration, and stress cases. Service-backed CI, including #28, must explicitly opt into the storage categories to retain that coverage.
Discovery synchronization overlaps #30, and storage isolation overlaps #33. These are alternative implementations, not independent changes to merge blindly. Unlike #33, this branch also makes local EKV opt-in. #31 adds complementary recovery assertions in the same files; #32 separately strengthens EKV teardown and dirty-state persistence coverage.