ext/intl: Fix Collator sort conversion error handling#22893
Open
LamentXU123 wants to merge 3 commits into
Open
ext/intl: Fix Collator sort conversion error handling#22893LamentXU123 wants to merge 3 commits into
LamentXU123 wants to merge 3 commits into
Conversation
LamentXU123
marked this pull request as ready for review
July 27, 2026 07:55
devnexen
reviewed
Jul 27, 2026
Member
|
not done reviewing will resume later, probably few more points down the road |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
Collator::sort(),collator_sort(),Collator::asort(), andcollator_asort()so string conversion failures during comparison are reported through the intl error mechanism instead of emitting a warning and continuing with an empty string.