ext/soap: to_zval_array() native stack overflow on cyclic encoded ref… - #22991
Open
devnexen wants to merge 2 commits into
Open
ext/soap: to_zval_array() native stack overflow on cyclic encoded ref…#22991devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
…erences. Fix php#22984 The array and apache Map decoders never registered the node being decoded, unlike to_zval_object_ex(), so a child href or enc:ref pointing back at an enclosing array recursed until the native stack was exhausted. An empty holder is now registered before the children are converted, and replaced by the completed value afterwards.
devnexen
marked this pull request as ready for review
August 1, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erences.
Fix #22984
The array and apache Map decoders never registered the node being decoded, unlike to_zval_object_ex(), so a child href or enc:ref pointing back at an enclosing array recursed until the native stack was exhausted. An empty holder is now registered before the children are converted, and replaced by the completed value afterwards.