Persist the pear/install-pear-nozlib.phar file - #23634
Conversation
There was once install-su Makefile rule, now the install-pear can be used instead. (cherry picked from commit 9aee546)
Rather than downloading it as part of the `makedist` script, add the script to the project's version control. The installation instructions are updated to indicate that the needed phar script is always present, and the only thing needed is to become the superuser and run `make install-pear`. The phar is currently marked as binary in the git attributes since it is not entirely text, it is committed as-is from the pear server and can be cleaned up in future commits. This also fixes the installation process when previously the installation would try to fallback to the `fetch.php` helper - it seems that the https stream wrapper is not included in PHP by default. Now that the phar is committed to version control, the `fetch.php` helper script is no longer needed. After this patch, `./configure --with-pear --enable-xml` allows installing pear with `make` without additional manual actions.
|
Why? We are trying to get rid of PEAR. |
|
CC @ashnazg - I see that you are still a bit active in updating https://github.com/pear/pear-core. This would switch from always bundling the latest version of the install-pear-nozlib.phar file (by downloading it at release time) to using a fixed, static version.
No objections to that, but currently we (release managers who run makedist, and anyone building from source) download the latest file directly from |
Right, okay didn't know that RMs downloaded the file rather than building it locally. |
3 participants
Rather than downloading it as part of the
makedistscript, add the script to the project's version control. The installation instructions are updated to indicate that the needed phar script is always present, and the only thing needed is to become the superuser and runmake install-pear.The phar is currently marked as binary in the git attributes since it is not entirely text, it is committed as-is from the pear server and can be cleaned up in future commits.
This also fixes the installation process when previously the installation would try to fallback to the
fetch.phphelper - it seems that the https stream wrapper is not included in PHP by default. Now that the phar is committed to version control, thefetch.phphelper script is no longer needed. After this patch,./configure --with-pear --enable-xmlallows installing pear withmakewithout additional manual actions.Also includes a cherry-pick of #14216 to update the instructions in
pear/install-pear.txt.