Skip to content

i18n(ja): restore particles dropped before nouns and copulas - #23322

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-noun-particles
Open

i18n(ja): restore particles dropped before nouns and copulas#23322
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-noun-particles

Conversation

@yahonda

@yahonda yahonda commented Jul 21, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Companion to #23318. That PR restored the particle between a code span and a following verb; the same pipeline also dropped it before a following noun or copula, which this PR covers.

EN: If the value of `store-io-pool-size` is `0`   -> `store-io-pool-size`の値が`0`の場合
EN: the value of `X`                              -> `X`の値
EN: If `header` is `false`                        -> `header`が`false`の場合
EN: either `cert`, `key`, or `auto-certs`         -> `cert` 、 `key` 、または`auto-certs`のいずれか

211 lines across 138 files. Particle distribution: の 197, が 31, を 27, は 22, で 16, に 10.

の dominates, but a quarter of the sites need something else, decided from the English each time:

  • `strict-picking-store`は… — EN "strict-picking-store controls…" (topic)
  • `select`で場合によっては誤った結果が返される — で rather than が, because the clause already carries 結果
  • `NULL`になります — the copula had lost に

Also fixed on the same lines

About 25 lines were scrambled, not merely missing a particle, and were repaired against the English. Two changed the meaning:

file was now
dm/dm-error-handling.md デフォルト値はmax_allowed_packetではなく64Mです max_allowed_packetデフォルト値は64Mです
literal-values.md 日付と時刻のリテラル値は'20170824' '2017-08-24'いずれか20170824日付として解釈します '20170824''2017-08-24'20170824のいずれかが日付として解釈されます

How it was checked

Every site read against release-8.5 before editing. 27 candidates were skipped as already correct — the detection regex is coarse, and these turned out to be compound nouns that take no particle (`TIMESTAMP`値 = EN "TIMESTAMP values", `Segment Split`中, `WHERE`句) or lines whose link text already ends in a plain-form verb ([接続する](…)場合).

Mechanical verification of the result:

  • link targets: 0 added, removed or altered; code spans: 0 invented or lost;
  • doubled particles (をを/はは/がが/にに/でで/のの): 0;
  • all changed lines are pure insertions apart from the ~25 scramble repairs noted above.

Left for a follow-up

A few sites cannot be fixed by inserting a particle:

  • optimizer-hints.md — EN "is used for Resource Control to isolate resources" was rendered 代わりに ("instead of"), inverting the meaning. Needs a reword.
  • tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md, changefeed-sink-to-mysql.md — the defect is inside the link text (…移行します + ときに), which must stay byte-identical.
  • releases/release-7.3.0.md — the correct fix collapses a duplicated link and code span into one, which the span-preservation rule forbids.

Relationship to the sibling PRs

Developed on top of the other open ja PRs and harmonized with them: all fifteen merge cleanly in any order (verified — 105 pairwise merges, 0 conflicts).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 293d4a9a-22e8-4388-a930-95ce96911391

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yahonda
yahonda force-pushed the i18n-ja-restore-noun-particles branch from 2b7d68b to d1e6a95 Compare July 21, 2026 07:18
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2026
@yahonda
yahonda force-pushed the i18n-ja-restore-noun-particles branch 4 times, most recently from 4c36041 to 2687dc5 Compare July 22, 2026 01:41
@yahonda
yahonda force-pushed the i18n-ja-restore-noun-particles branch 4 times, most recently from 8523cac to c521cc6 Compare July 24, 2026 01:03
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2026
@yahonda
yahonda force-pushed the i18n-ja-restore-noun-particles branch from a45ea32 to 6b1ee9a Compare July 30, 2026 06:43
@yahonda
yahonda marked this pull request as ready for review July 30, 2026 06:43
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 30, 2026
Rebased onto the current i18n-ja-release-8.5 tip. Restores Japanese particles
(の/を/が/は) the MT pipeline dropped after code spans before nouns and copulas
(e.g. `X`の値, `X`を追加します, `X`の場合), and repairs the associated sentence
scrambles. Verified 1:1 against the English source; also fixed a few residual
particle drops the pass had left on partially-repaired lines.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-restore-noun-particles branch from 6b1ee9a to 9996242 Compare July 31, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants