Skip to content

i18n(ja): fix unnatural phrasing and misplaced issue-link - #23438

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-third-party-tools-fluency
Aug 5, 2026
Merged

i18n(ja): fix unnatural phrasing and misplaced issue-link#23438
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-third-party-tools-fluency

Conversation

@yahonda

@yahonda yahonda commented Aug 5, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Two small fluency/structure fixes spotted while reviewing nearby files:

  • develop/dev-guide-third-party-tools-compatibility.md: "...に見られます" (are seen in) read unnaturally for "issues found in some third-party tools". Changed to "...で発生します" (occur in), a more natural verb choice for this subject.
  • functions-and-operators/encryption-and-compression-functions.md: the GitHub issue link [問題 #2632] had been inserted in the middle of the sentence, between "MySQL Enterprise" and "でのみ利用可能な関数", splitting the phrase "functions only available in MySQL Enterprise". Moved the link to the end of the sentence, matching the English source's structure (... only available in MySQL Enterprise [Issue #2632](...).).

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (LTS)
  • v8.1 (LTS)
  • v7.5 (LTS)
  • v7.1 (LTS)
  • v6.5 (LTS)
  • v6.1 (LTS)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Add redirect rules
  • Change the framework or the code logic of the repository

- dev-guide-third-party-tools-compatibility.md: "...に見られます" (are seen
  in) read unnaturally for "issues found in some third-party tools"; changed
  to "...で発生します" (occur in), a more natural verb for this subject.
- encryption-and-compression-functions.md: the GitHub issue link had been
  inserted in the middle of the sentence, between "MySQL Enterprise" and
  "でのみ利用可能な関数" (splitting the phrase "functions only available in
  MySQL Enterprise"). Moved the link to the end of the sentence, matching
  the English source's structure.
@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/develop This PR relates to the area of TiDB App development. labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd5fab46-2587-479c-af55-e7f4c1d26b3d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2026
@yahonda
yahonda marked this pull request as ready for review August 5, 2026 06:11
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 5, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2026
@qiancai
qiancai merged commit a7efa85 into pingcap:i18n-ja-release-8.5 Aug 5, 2026
4 of 9 checks passed
@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-05 12:26:55.826462654 +0000 UTC m=+2617401.862557711: ☑️ agreed by qiancai.

@yahonda
yahonda deleted the i18n-ja-third-party-tools-fluency branch August 6, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants