Skip to content

i18n(ja): restore literal SQL command syntax in system-variable-reference.md links - #23446

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-show-global-session-variables-literal
Aug 6, 2026
Merged

i18n(ja): restore literal SQL command syntax in system-variable-reference.md links#23446
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-show-global-session-variables-literal

Conversation

@yahonda

@yahonda yahonda commented Aug 5, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The literal SQL command references SHOW [GLOBAL|SESSION] VARIABLES (99 occurrences) and CREATE [GLOBAL|SESSION] BINDING (2 occurrences) in system-variable-reference.md's "See also" link lists had been translated word-for-word into Japanese ([[グローバル|セッション]変数を表示] / [[グローバル|セッション]バインディングの作成]), turning literal command syntax a user would type verbatim into unreadable, non-functional prose. Restored to match the English source exactly (101 lines changed, 1 file).

Known benign conflict: this PR has an adjacent-line diff-context conflict with #23437 (both touch system-variable-reference.md, on consecutive lines within the same "See also" list — #23437 changes MySQLの互換性MySQLとの互換性 on one line, this PR changes the next line). The actual changes don't overlap in content; it's a standard git 3-line-context collision, trivially resolved by a rebase whichever PR merges second.

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (LTS)
  • v8.1 (LTS)
  • v7.5 (LTS)
  • v7.1 (LTS)
  • v6.5 (LTS)
  • v6.1 (LTS)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Add redirect rules
  • Change the framework or the code logic of the repository

@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 90739cc1-5498-423c-a8dc-f68c608565bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2026
@yahonda
yahonda marked this pull request as ready for review August 5, 2026 06:29
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 5, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-05 12:29:43.590999202 +0000 UTC m=+2617569.627094268: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2026
@yahonda
yahonda force-pushed the i18n-ja-show-global-session-variables-literal branch from ea27681 to 488de9b Compare August 6, 2026 00:14
…ence.md links

The literal SQL command references "SHOW [GLOBAL|SESSION] VARIABLES" (99
occurrences) and "CREATE [GLOBAL|SESSION] BINDING" (2 occurrences) had been
translated word-for-word into Japanese ("[[グローバル|セッション]変数を表示]"
/ "[[グローバル|セッション]バインディングの作成]"), turning literal command
syntax a user would type verbatim into unreadable, non-functional prose.
Restored to match the English source exactly.
@yahonda
yahonda force-pushed the i18n-ja-show-global-session-variables-literal branch from 488de9b to fa713bd Compare August 6, 2026 04:03
@ti-chi-bot

ti-chi-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

@qiancai: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai
qiancai merged commit 2f1de99 into pingcap:i18n-ja-release-8.5 Aug 6, 2026
5 of 9 checks passed
@yahonda
yahonda deleted the i18n-ja-show-global-session-variables-literal branch August 7, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants