Skip to content

i18n(ja): restore dropped particles after code spans in two SQL/TiCDC docs - #23447

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-start-transaction-particle-fix
Aug 6, 2026
Merged

i18n(ja): restore dropped particles after code spans in two SQL/TiCDC docs#23447
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-start-transaction-particle-fix

Conversation

@yahonda

@yahonda yahonda commented Aug 5, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

  • sql-statements/sql-statement-start-transaction.md: the START TRANSACTION MySQL-compatibility bullet was missing the は particle after every `START TRANSACTION` code span (3 places), producing a run-on, ungrammatical sentence. Restored particles to match the English source's three clauses (TiDB behavior / MySQL behavior / the WITH CONSISTENT SNAPSHOT equivalence). Fixed the same missing-は defect in the adjacent START TRANSACTION READ ONLY bullet.
  • ticdc/ticdc-faq.md:
    • "詳細はMySQLの互換性ご覧ください" was missing the を particle before the verb. Restored to "...をご覧ください", and also applied MySQLの互換性 -> MySQLとの互換性 on this line (matching i18n(ja): unify MySQL-compatibility term translation #23437's term unification, to reduce cross-PR churn).
    • Reordered "TiDBのデフォルト値explicit_defaults_for_timestampがMySQLと異なる" (awkward: reads as "TiDB's default value explicit_defaults_for_timestamp") to "TiDBのexplicit_defaults_for_timestampのデフォルト値がMySQLと異なる", matching the English's modifier order: "the default value of explicit_defaults_for_timestamp in TiDB".

Known benign conflict: this PR and #23437 both touch the same physical line in ticdc-faq.md (line-level, not content-level — my version already includes their term change plus additional independent fixes). Standard git line-collision, trivial to resolve on rebase whichever merges second.

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (LTS)
  • v8.1 (LTS)
  • v7.5 (LTS)
  • v7.1 (LTS)
  • v6.5 (LTS)
  • v6.1 (LTS)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Add redirect rules
  • Change the framework or the code logic of the repository

@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e00001d0-7e7f-499b-9c05-cc010a4485ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2026
@yahonda
yahonda force-pushed the i18n-ja-start-transaction-particle-fix branch from d883ec5 to f2bcd55 Compare August 5, 2026 06:20
@yahonda
yahonda marked this pull request as ready for review August 5, 2026 06:29
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 5, 2026
@yahonda
yahonda force-pushed the i18n-ja-start-transaction-particle-fix branch from f2bcd55 to 276c450 Compare August 6, 2026 00:16
… docs

- sql-statement-start-transaction.md: the START TRANSACTION compatibility
  bullet was missing は after every `START TRANSACTION` code span (3
  places), producing a run-on, ungrammatical sentence. Restored particles to
  match the English source's three clauses (TiDB behavior / MySQL behavior /
  the WITH CONSISTENT SNAPSHOT equivalence).
- Fixed the same missing-は defect in the adjacent START TRANSACTION READ
  ONLY bullet.
- ticdc-faq.md: "詳細は[MySQLの互換性](...)ご覧ください" was missing the を
  particle before the verb. Restored to "...をご覧ください", and also applied
  MySQLの互換性 -> MySQLとの互換性 here (matching pingcap#23437's term unification,
  to avoid a needless cross-PR conflict on this line).
- ticdc-faq.md: reordered "TiDBのデフォルト値`explicit_defaults_for_timestamp`
  がMySQLと異なる" (awkward: reads as "TiDB's default value
  explicit_defaults_for_timestamp") to "TiDBの`explicit_defaults_for_timestamp`
  のデフォルト値がMySQLと異なる", matching the English's modifier order:
  "the default value of `explicit_defaults_for_timestamp` in TiDB".
@yahonda
yahonda force-pushed the i18n-ja-start-transaction-particle-fix branch from 276c450 to 0100ce1 Compare August 6, 2026 04:02
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 6, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-06 05:31:24.388625376 +0000 UTC m=+2678870.424720432: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit dd23755 into pingcap:i18n-ja-release-8.5 Aug 6, 2026
5 of 9 checks passed
@yahonda
yahonda deleted the i18n-ja-start-transaction-particle-fix branch August 7, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants