i18n(ja): restore dropped particles after code spans in two SQL/TiCDC docs - #23447
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
d883ec5 to
f2bcd55
Compare
f2bcd55 to
276c450
Compare
… docs - sql-statement-start-transaction.md: the START TRANSACTION compatibility bullet was missing は after every `START TRANSACTION` code span (3 places), producing a run-on, ungrammatical sentence. Restored particles to match the English source's three clauses (TiDB behavior / MySQL behavior / the WITH CONSISTENT SNAPSHOT equivalence). - Fixed the same missing-は defect in the adjacent START TRANSACTION READ ONLY bullet. - ticdc-faq.md: "詳細は[MySQLの互換性](...)ご覧ください" was missing the を particle before the verb. Restored to "...をご覧ください", and also applied MySQLの互換性 -> MySQLとの互換性 here (matching pingcap#23437's term unification, to avoid a needless cross-PR conflict on this line). - ticdc-faq.md: reordered "TiDBのデフォルト値`explicit_defaults_for_timestamp` がMySQLと異なる" (awkward: reads as "TiDB's default value explicit_defaults_for_timestamp") to "TiDBの`explicit_defaults_for_timestamp` のデフォルト値がMySQLと異なる", matching the English's modifier order: "the default value of `explicit_defaults_for_timestamp` in TiDB".
276c450 to
0100ce1
Compare
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
sql-statements/sql-statement-start-transaction.md: theSTART TRANSACTIONMySQL-compatibility bullet was missing the は particle after every`START TRANSACTION`code span (3 places), producing a run-on, ungrammatical sentence. Restored particles to match the English source's three clauses (TiDB behavior / MySQL behavior / theWITH CONSISTENT SNAPSHOTequivalence). Fixed the same missing-は defect in the adjacentSTART TRANSACTION READ ONLYbullet.ticdc/ticdc-faq.md:MySQLの互換性->MySQLとの互換性on this line (matching i18n(ja): unify MySQL-compatibility term translation #23437's term unification, to reduce cross-PR churn).explicit_defaults_for_timestampがMySQLと異なる" (awkward: reads as "TiDB's default value explicit_defaults_for_timestamp") to "TiDBのexplicit_defaults_for_timestampのデフォルト値がMySQLと異なる", matching the English's modifier order: "the default value ofexplicit_defaults_for_timestampin TiDB".Known benign conflict: this PR and #23437 both touch the same physical line in
ticdc-faq.md(line-level, not content-level — my version already includes their term change plus additional independent fixes). Standard git line-collision, trivial to resolve on rebase whichever merges second.Which TiDB version(s) do your changes apply to? (Required)
Do your changes match any of the following descriptions?