Skip to content

i18n(ja): fix dropped predicates in list-ending sentences - #23831

Merged
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dropped-predicate-list-endings
Sep 16, 2026
Merged

qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dropped-predicate-list-endings

Conversation

@yahonda

@yahonda yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Eight sentences across the corpus followed the same defect pattern: a subject introduces a comma-separated list of values/options/formats, and the sentence's own verb or copula was dropped, leaving the sentence ending abruptly right after the last list item (e.g. ...、および\local` 。` with nothing between the last term and the period).

Each site was individually verified against its English source to confirm a real predicate is missing, as opposed to a colon-introduced label:value listing (which correctly has no verb in EN either — tikv-configuration-file.md's "Value options: true, false, ..." was checked and correctly left alone, since it mirrors the EN's own colon-list structure).

Fixed sites:

  • functions-and-operators/json-functions/json-functions-validate.md: missing が含まれます (EN: "include")
  • partitioned-table.md: missing predicate for "can be" (EN: "can be")
  • releases/release-5.0.0.md: missing です (EN: "are")
  • releases/release-6.6.0.md: missing です (EN: "are")
  • sql-statements/sql-statement-create-index.md: missing です (EN: "are")
  • tidb-cloud/migrate-from-op-tidb.md and its premium sibling tidb-cloud/premium/migrate-from-op-tidb-premium.md: missing をサポートしています (EN: "supports")
  • tidb-cloud/naming-conventions-for-data-import.md (2 sites, same sentence repeated twice in the file): missing をサポートしています (EN: "supports")

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Improved Japanese punctuation and sentence structure across release notes and SQL statement documentation.
    • Clarified references to system variable documentation related to CREATE INDEX.
    • Completed migration guidance for supported incremental replication schemes, including MySQL, TiDB, Kafka, S3, and local destinations.
    • Clarified that TiDB Cloud supports .gzip, .gz, .zstd, .zst, and .snappy compression formats for CSV and SQL imports.

Eight sentences across the corpus followed the same pattern: a
subject introduces a comma-separated list of values/options/formats,
and the sentence's own verb or copula was dropped, leaving the
sentence ending abruptly right after the last list item. Each site
was individually verified against its EN source to confirm a real
predicate is missing (as opposed to a colon-introduced label:value
listing, which correctly has no verb in EN either, e.g.
tikv-configuration-file.md's "Value options: ..." was checked and
left alone).

- functions-and-operators/json-functions/json-functions-validate.md:
  missing "が含まれます" (EN: "include")
- partitioned-table.md: missing predicate for "can be" (EN: "can be")
- releases/release-5.0.0.md: missing "です" (EN: "are")
- releases/release-6.6.0.md: missing "です" (EN: "are")
- sql-statements/sql-statement-create-index.md: missing "です" (EN: "are")
- tidb-cloud/migrate-from-op-tidb.md and its premium sibling: missing
  "をサポートしています" (EN: "supports")
- tidb-cloud/naming-conventions-for-data-import.md (2 sites, same
  sentence repeated in the file): missing "をサポートしています"
  (EN: "supports")

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b0a328fe-d725-4334-b2d7-59db2c10dfa0

📥 Commits

Reviewing files that changed from the base of the PR and between 1ddaba2 and 144b75f.

📒 Files selected for processing (4)
  • releases/release-5.0.0.md
  • releases/release-6.6.0.md
  • tidb-cloud/migrate-from-op-tidb.md
  • tidb-cloud/premium/migrate-from-op-tidb-premium.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR corrects Japanese sentence endings, punctuation, and wording in release notes, CREATE INDEX documentation, and TiDB Cloud migration and data import guides.

Changes

Documentation corrections

Layer / File(s) Summary
Configuration documentation wording
releases/release-5.0.0.md, releases/release-6.6.0.md, sql-statements/sql-statement-create-index.md
Corrected punctuation and sentence endings for clustered-index, TiSpark, and CREATE INDEX system variable descriptions.
TiDB Cloud documentation wording
tidb-cloud/migrate-from-op-tidb.md, tidb-cloud/premium/migrate-from-op-tidb-premium.md, tidb-cloud/naming-conventions-for-data-import.md
Completed descriptions for supported sink URI schemes and compression formats.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to 144b7

The changes complete Japanese documentation sentences without altering functional behavior, so the PR is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing omitted predicates in Japanese list-ending sentences.
Description check ✅ Passed The description explains the changes, identifies the affected files and missing predicates, specifies the target documentation version, records AI involvement, and addresses the repository checklist. …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a94c8b30-c0fd-4df0-99db-b99389e5f794

📥 Commits

Reviewing files that changed from the base of the PR and between 645c2ff and c2eecdd.

📒 Files selected for processing (8)
  • functions-and-operators/json-functions/json-functions-validate.md
  • partitioned-table.md
  • releases/release-5.0.0.md
  • releases/release-6.6.0.md
  • sql-statements/sql-statement-create-index.md
  • tidb-cloud/migrate-from-op-tidb.md
  • tidb-cloud/naming-conventions-for-data-import.md
  • tidb-cloud/premium/migrate-from-op-tidb-premium.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread sql-statements/sql-statement-create-index.md Outdated
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 15, 2026
…dropped-predicate-list-endings-local

# Conflicts:
#	functions-and-operators/json-functions/json-functions-validate.md
#	partitioned-table.md
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-16 15:12:17.730710313 +0000 UTC m=+217983.668367907: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 6fd8538 into pingcap:i18n-ja-release-8.5 Sep 16, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants