Skip to content

i18n(ja): keep gauge/count/histogram metric type values in English - #23841

Open
yahonda wants to merge 4 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-metric-type-english-terms
Open

yahonda wants to merge 4 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-metric-type-english-terms

Conversation

@yahonda

@yahonda yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

In the Japanese translations of the Datadog, New Relic, and Prometheus/Grafana
integration docs, the "metric type" column had translated the literal metric
type values into katakana:

  • gauge -> ゲージ
  • count -> カウント
  • histogram -> ヒストグラム

These are literal enum values from each monitoring system's own API/metadata
(matching the English source verbatim), not prose to translate, so this PR
reverts them to English. This also makes monitor-datadog-integration.md
consistent with its sibling monitor-datadog-integration-for-tidb-x.md,
which already kept these values in English.

Additionally, the changefeed_status metric's value-description column
(Unknown/Normal/Warning/Failed/Stopped/Finished/Other, describing
what each numeric value -1/0/1/2/3/4/6/7 means) had likewise been translated
to Japanese in all 4 files. These are literal value-display labels matching
TiDB Cloud's own monitoring dashboards, not prose, so they are reverted to
English as well.

Files changed:

  • tidb-cloud/monitor-datadog-integration.md
  • tidb-cloud/monitor-new-relic-integration.md
  • tidb-cloud/monitor-prometheus-and-grafana-integration.md
  • tidb-cloud/prometheus-grafana-integration.md

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

The metric type column in the Datadog, New Relic, and Prometheus/Grafana
integration docs had been translated to katakana (gauge -> ゲージ,
count -> カウント, histogram -> ヒストグラム). These are literal metric
type values from the monitoring systems' own APIs, matching the English
source and the untranslated sibling doc (monitor-datadog-integration-for-tidb-x.md),
so they should stay in English.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e663c5dd-6f18-475d-9541-9ff2f618ec4b

📥 Commits

Reviewing files that changed from the base of the PR and between f96ca2d and f6d17f0.

📒 Files selected for processing (4)
  • tidb-cloud/monitor-datadog-integration.md
  • tidb-cloud/monitor-new-relic-integration.md
  • tidb-cloud/monitor-prometheus-and-grafana-integration.md
  • tidb-cloud/prometheus-grafana-integration.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 240bdc72-dab5-451f-969f-f55c85d70a96

📥 Commits

Reviewing files that changed from the base of the PR and between 645c2ff and f96ca2d.

📒 Files selected for processing (4)
  • tidb-cloud/monitor-datadog-integration.md
  • tidb-cloud/monitor-new-relic-integration.md
  • tidb-cloud/monitor-prometheus-and-grafana-integration.md
  • tidb-cloud/prometheus-grafana-integration.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates four TiDB Cloud monitoring documentation files. Metric types and selected table labels now use English terms. Metric names, labels, descriptions, and table structures remain unchanged except for two related description parentheticals.

Changes

Metric terminology alignment

Layer / File(s) Summary
Monitoring metric-type terminology
tidb-cloud/monitor-datadog-integration.md, tidb-cloud/monitor-new-relic-integration.md, tidb-cloud/monitor-prometheus-and-grafana-integration.md
Metric-type values change from Japanese terms to gauge, count, and histogram. Two replication-lag descriptions change ゲージ to gauge.
Plan table labels
tidb-cloud/prometheus-grafana-integration.md
Essential and Premium tables change metric-type headers to gauge and label headers to Labels.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to f96ca

This PR aligns metric terminology in the Japanese monitoring documentation and presents no concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: keeping metric type values in English in the Japanese documentation.
Description check ✅ Passed The description includes the required change summary, affected version, related-links section, AI involvement, and scope checklist. It clearly explains the metric terminology updates. However, its cla…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2026
The previous commit's blanket replacement incorrectly turned the prose
description "ステートメントの期間ヒストグラム" (a natural Japanese
statistics term) into "ステートメントの期間histogram". Only the Type
column's literal metric-type value should stay in English; restore the
katakana term in the prose description.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda marked this pull request as ready for review September 14, 2026 04:25
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2026
The Unknown/Normal/Warning/Failed/Stopped/Finished/Other labels describe
literal numeric values (-1/0/1/2/3/4/6/7) that the changefeed_status gauge
metric returns, matching the value-display labels used by TiDB Cloud's
own monitoring dashboards. Like the metric type values fixed earlier in
this PR, these are literal values rather than prose to translate, so keep
them in English, matching the English source.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 15, 2026
…ja-metric-type-english-terms-local

# Conflicts:
#	tidb-cloud/monitor-datadog-integration.md
#	tidb-cloud/monitor-new-relic-integration.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants