Skip to content

fix: point _index.md TiDB Self-Managed links to stable instead of unpublished v8.5 - #23847

Merged
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-index-tidb-configuration-file-link
Sep 15, 2026
Merged

qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-index-tidb-configuration-file-link

Conversation

@yahonda

@yahonda yahonda commented Sep 14, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

_index.md's "TiDB Self-Managed" page had 38 reference links pointing to
https://docs.pingcap.com/ja/tidb/v8.5/..., but the Japanese v8.5 docs are
not published yet, so every one of these links 404s. This PR points all
38 links at stable instead, which resolves correctly for every path.

Verified before/after for all 36 unique paths used in this file:

  • Before: https://docs.pingcap.com/ja/tidb/v8.5/<path> -> 404 (all 36)
  • After: https://docs.pingcap.com/ja/tidb/stable/<path> -> 200 (all 36)

Originally flagged by CodeRabbit on PR #23832 (a separate configuration-terminology PR) for just one of these 38 links (tidb-configuration-file); a repo-wide check found only 2 other files reference /ja/tidb/v8.5/ at all, and both are aliases: front-matter entries (a page's own future-alias declaration, not a clickable link), so out of scope here.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated Japanese TiDB Self-Managed navigation links to use stable documentation paths across the Learn, Try, Deploy, Migrate, Maintain, Monitor, Tune, Tools, and Reference sections.
    • Updated the Kubernetes deployment link to the stable TiDB in Kubernetes documentation path.
    • Kept the release-notes link unchanged.

…hed v8.5

The ja/tidb/v8.5/tidb-configuration-file route is not yet published and
returns 404; ja/tidb/stable/tidb-configuration-file resolves (200). Point
the link at stable until the v8.5 Japanese docs are published.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3c05fa8a-d40b-4a59-aa5b-1f645e923427

📥 Commits

Reviewing files that changed from the base of the PR and between ca92681 and 874697e.

📒 Files selected for processing (1)
  • _index.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Japanese TiDB Self-Managed navigation links now use stable documentation paths. The Kubernetes deployment link uses the tidb/stable/tidb-in-kubernetes/ path. The release-notes link remains unchanged.

Changes

Japanese navigation links

Layer / File(s) Summary
Update navigation documentation paths
_index.md
Learn, Try, deployment, migration, maintenance, monitoring, tuning, tools, and reference links use stable instead of v8.5. The Kubernetes link uses the new stable path. The release-notes link is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 87469

The navigation links are updated to stable documentation paths, with no remaining merge-blocking issue identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating TiDB Self-Managed links from the unpublished v8.5 path to the stable path.
Description check ✅ Passed The description explains the reason for the change, the affected file and links, verification results, applicable version, reference link, AI involvement, and change-category checkboxes. The first-tim…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2026
… v8.5

The other 37 ja/tidb/v8.5/... links in this file 404 for the same reason
as the tidb-configuration-file link fixed in the previous commit: the
Japanese v8.5 docs are not published yet. Point all of them at stable,
which resolves (200) for every path.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda yahonda changed the title fix: point TiDB configuration file link to stable instead of unpublished v8.5 fix: point _index.md TiDB Self-Managed links to stable instead of unpublished v8.5 Sep 14, 2026
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2026
@yahonda

yahonda commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 33 minutes.

@yahonda

yahonda commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 19d254e6-0f9e-4430-9534-b05d51e2fcb6

📥 Commits

Reviewing files that changed from the base of the PR and between 645c2ff and ca92681.

📒 Files selected for processing (1)
  • _index.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread _index.md Outdated
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-15 13:32:43.706753393 +0000 UTC m=+125609.644410977: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 15, 2026
@qiancai
qiancai merged commit b857207 into pingcap:i18n-ja-release-8.5 Sep 15, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants