Conversation
…idb-lightning Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughChangesThe pull request updates Japanese TiDB Lightning documentation. It corrects wording, spacing, headings, configuration names, version requirements, monitoring labels, and troubleshooting descriptions. It also translates several English sentences. TiDB Lightning documentation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: 🔵 Low · up to The documentation could mislead operators about disk-quota coverage and supported logical-import cluster versions; both issues are localized and straightforward to correct. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: e5425d6f-21fd-489a-9ade-672fbd7a9f3f
📒 Files selected for processing (17)
tidb-lightning/data-import-best-practices.mdtidb-lightning/import-into-vs-tidb-lightning.mdtidb-lightning/monitor-tidb-lightning.mdtidb-lightning/tidb-lightning-checkpoints.mdtidb-lightning/tidb-lightning-configuration.mdtidb-lightning/tidb-lightning-data-source.mdtidb-lightning/tidb-lightning-error-resolution.mdtidb-lightning/tidb-lightning-faq.mdtidb-lightning/tidb-lightning-glossary.mdtidb-lightning/tidb-lightning-logical-import-mode-usage.mdtidb-lightning/tidb-lightning-logical-import-mode.mdtidb-lightning/tidb-lightning-overview.mdtidb-lightning/tidb-lightning-physical-import-mode-usage.mdtidb-lightning/tidb-lightning-physical-import-mode.mdtidb-lightning/tidb-lightning-prechecks.mdtidb-lightning/tidb-lightning-web-interface.mdtidb-lightning/troubleshoot-tidb-lightning.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
…int MD037 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
qiancai
added
translation/no-need
…tidb-lightning-defects # Conflicts: # tidb-lightning/import-into-vs-tidb-lightning.md
2 participants
What is changed, added or deleted? (Required)
Fixes defects found during a full 1:1 EN-vs-JA read-through review of every
file in
tidb-lightning/(22 files). All fixes were individually re-verifiedagainst the live JA file and the EN source (
release-8.5) before beingapplied.
Most significant fixes:
tidb-lightning-prechecks.md(all 8 table rows) andtidb-lightning-overview.md:version-requirement values like
>= 5.3.0("5.3.0 or later") had all losttheir
>=, rendering as bare= 5.3.0("exactly 5.3.0") — a real changein the compatibility requirement communicated to readers.
tidb-lightning-faq.md: "the earliest available version" mistranslated as"the latest available version," reversing the meaning.
tidb-lightning-glossary.md: the alphabetical section lettersIandNwere mistranslated as real words (私 "I/me", 北 "North"), breaking the
glossary's alphabetical index; also fixed
A(was hiragana あ) forconsistency with the other literal Latin-letter headings.
tidb-lightning-configuration.md: 4 literal TOML section names weremistranslated (
security→安全,conflict→対立,cron→クローン "clone",tidb→ティッド, a garbled transliteration) — these must stay as the literalconfig-file section names.
tidb-lightning-error-resolution.md: a heading for "Type error" wastranslated as "入力エラー" ("Input error"), contradicting the correct "型エラー"
used elsewhere in the same file; also fixed a garbled parameter enumeration
and a qualified SQL identifier that had lost its
.separator.troubleshoot-tidb-lightning.md: the supported-compression-format list wasmissing
zstdentirely (EN listsgzip,snappy, andzstd).monitor-tidb-lightning.md/import-into-vs-tidb-lightning.md: severalfully-untranslated English sentences/table cells were translated, and a
metric series name "apply worker" (mistranslated as "応募者", "job
applicant") was restored to its literal form.
tidb-lightning-web-interface.md: a "Function" column header wasmistranslated as 関数 (math/programming sense) instead of 機能, and the
literal UI button
UPLOADhad been translated into Japanese while itssibling buttons stay English.
The rest are dropped を/が/は/の particles (mostly right after a closing code
span or link, a recurring pattern in this corpus) and a couple of scrambled
sentences reconstructed to match the EN meaning.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit