Skip to content

fix(web): choose a server for grouped projects - #8012

Open
StiensWout wants to merge 3 commits into
pingdotgg:mainfrom
StiensWout:t3code/show-project-servers
Open

fix(web): choose a server for grouped projects#8012
StiensWout wants to merge 3 commits into
pingdotgg:mainfrom
StiensWout:t3code/show-project-servers

Conversation

@StiensWout

@StiensWout StiensWout commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Grouped projects can exist on more than one T3 environment, but the new-thread picker only showed the representative server. The sidebar also treated that group as a single choice, so it skipped the picker even though the user still had to choose where the thread should run.

This shows the server count on grouped project rows and opens a Run on list with every server and workspace path. The sidebar button and chat.new shortcut now count server destinations, while single-server projects and the direct-create shortcut keep their existing behavior.

Proof

Before

The grouped project row showed one server with no indication that another copy existed.

Before: grouped project row showed only one server

After

The row shows 2 servers.

After: grouped project row shows 2 servers

Opening the row shows the full server list. Playwright also selected workbench-01 and confirmed the composer changed its Run on value.

After: Run on list shows every server and workspace

Verification

  • Web TypeScript check
  • Command palette logic, 17 tests
  • Environment grouping, 13 tests
  • Sidebar logic, 105 tests
  • Playwright pass against two disposable connected environments

Created by GPT-5.6-Sol through the Codex harness in T3 Code.


Note

Medium Risk
Changes when new threads are created vs routed through the picker, so a destination-count bug could skip the picker or create threads on the wrong environment.

Overview
New threads for a grouped project now treat each unique environment as a destination, not the group as a single choice.

The command palette “New thread in…” row shows a server count and opens a Run on submenu with every server and workspace path. The sidebar new-thread button and chat.new use the same destination count, so a single grouped project on two servers still opens the picker. Shift-click / chat.newLocal still create in the current project.

Primary environment labels in the palette use resolveEnvironmentOptionLabel instead of a hardcoded “Local”.

Reviewed by Cursor Bugbot for commit db5c47c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Show server destination picker for grouped projects in Command Palette

  • Adds countNewThreadDestinations and listNewThreadProjectDestinations to count and list distinct environment destinations across grouped projects
  • Command Palette 'New thread in…' section now shows a submenu when a project has multiple server destinations, letting users pick the environment; single-destination projects remain a direct action with an icon and label
  • Sidebar 'New thread' button and chat.new shortcut now open the picker based on destination count instead of project group count
  • enumerateCommandPaletteItems accepts CommandPaletteSubmenuItem alongside action items
  • Primary environment label resolves via resolveEnvironmentOptionLabel instead of a hardcoded 'Local' string
  • Behavioral Change: shouldCreateNewThreadInCurrentProject parameter renamed from projectGroupCount to destinationCount; callers in Sidebar.tsx and _chat.tsx now pass distinct environment counts

Macroscope summarized db5c47c.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 73e0e5dd-b662-4220-ac5a-23d5e55b323a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 23, 2026

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two UI consistency findings in the new "New thread in..." destination rows. Details inline.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/CommandPalette.tsx Outdated
Comment thread apps/web/src/components/CommandPalette.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 399d9c8. Configure here.

Comment thread apps/web/src/components/CommandPalette.tsx
@macroscopeapp

macroscopeapp Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR changes new-thread routing across the command palette, sidebar button, and global shortcut, adding a server-selection submenu for grouped projects. Because the selected environment determines where the thread is created, the cross-cutting user-facing behavior warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the latest commit drops the local/remote environment icon distinction in the new-thread destination rows.

Posted via Macroscope — UI Consistency

Comment thread apps/web/src/components/CommandPalette.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant