Skip to content

fix(clients): sort project menus alphabetically - #8025

Open
davidhu2000 wants to merge 1 commit into
pingdotgg:mainfrom
davidhu2000:fix/alphabetize-project-menus
Open

fix(clients): sort project menus alphabetically#8025
davidhu2000 wants to merge 1 commit into
pingdotgg:mainfrom
davidhu2000:fix/alphabetize-project-menus

Conversation

@davidhu2000

@davidhu2000 davidhu2000 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Project filter menus inherited activity or manual project ordering, making projects harder to scan when choosing a scope.

Sort filter-menu options alphabetically by display label across web, desktop, and mobile while preserving the configured ordering of the main project lists. The web sidebar memoizes its derived menu order because the sidebar rerenders frequently as thread state changes.

Screenshot 2026-08-23 at 1 01 33 PM

Testing

  • Mobile typecheck
  • Focused lint and formatting checks
  • Manually verified the web menu with an isolated fixture: Alpha Studio, Metro Docs, Zulu Analytics

Generated with GPT-5.6-Sol via the Codex harness in T3 Code.

Note

Sort project menus alphabetically in mobile and web sidebars

  • Sorts projectFilterOptions by label in HomeRouteScreen and ThreadNavigationSidebarPane using toSorted with localeCompare
  • Introduces a memoized projectScopeMenuGroups in web Sidebar that sorts projectGroups by displayName and renders MenuRadioItems from it
  • Behavioral Change: project scope options now appear in alphabetical order in all three menus; sorting relies on localeCompare defaults

Macroscope summarized 2dbb967.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e3b2ae8-290f-41de-b3cc-1be541a557fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 changed lines (additions + deletions). label Aug 23, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change is otherwise limited to ordering project-scope menu entries and preserves the configured ordering of the main lists. Both mobile paths newly depend on toSorted, despite the mobile codebase documenting that Hermes lacks this API, creating a runtime compatibility concern.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant