feat(web): show notice instead of app in Tesla in-car browsers - #8032
feat(web): show notice instead of app in Tesla in-car browsers#8032abcdmku wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d3bea34 to
8121782
Compare
There was a problem hiding this comment.
One finding: the new Tesla gate renders an unstyled bare text node as the entire app UI, bypassing the app's full-screen surface and theme tokens. Details inline.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
One consistency finding: the Tesla gate renders a bare text node as the entire app UI, bypassing the app's full-screen notice pattern and theme tokens.
Posted via Macroscope — UI Consistency
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a new user-agent-based runtime branch that replaces the application and authentication-provider tree with a Tesla-specific notice. Although the diff is small and isolated, it changes the user-facing entry path and gates the main workflow for detected browsers. You can add or adjust custom eligibility rules. Learn more. |
Detects the Tesla/<version> UA token (QtCarBrowser on older models) and renders only "T3 Code does not endorse this behavior". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review feedback: the bare text node bypassed the boot surface and theme tokens. Wrap the notice in the standard full-screen centered container using bg-background/text-foreground. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
56aded6 to
a231dfb
Compare
|
Well that's not very fun |
Summary
Tesla/<version>token;QtCarBrowseron older Model S/X) in the web entry pointTest plan
npm run typecheckinapps/webpassesTesla/2024.xand load the web UI: only the notice rendersScreenshots
Before (normal browser)
After (Tesla in-car UA)
🤖 Generated with Claude Code
Note
Low Risk
Small client-side UA gate at bootstrap only; no auth, data, or API changes. False positives would hide the app for matching UAs.
Overview
Tesla in-car browsers no longer boot the web app.
main.tsxmatchesTesla/orQtCarBrowserin the user agent and renders a centered “T3 Code does not endorse this behavior” message instead of Clerk, auth, andAppRoot. Other browsers and Electron are unchanged.Reviewed by Cursor Bugbot for commit a231dfb. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show static notice instead of app for Tesla browsers in
main.tsxisTeslaCarBrowserdetection by testingnavigator.userAgentagainst/Tesla\/|QtCarBrowser/ReactDOM.createRootbootstrap in main.tsx to render a centered static message div when the Tesla browser is detectedReact.StrictModeandClerk/ElectronClerkproviders, receiving a static message instead of mounting the full applicationMacroscope summarized a231dfb.