Skip to content

Improve report icons and add dark mode support - #6673

Merged
sanne-san merged 1 commit into
masterfrom
sanne-report-icons
Sep 15, 2026
Merged

sanne-san merged 1 commit into
masterfrom
sanne-report-icons

Conversation

@sanne-san

@sanne-san sanne-san commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Fallback icons were stuck on one fixed gray (the old gray palette), because an SVG inside an <img> cannot see the dark class. Moved away from hardcoding colors; the browser and OS icons are now inline, and the link favicon has a dark variant
  • All report icons now share one line style, and follow the same color scheme

Before:

Capture-2026-09-12-170251 Capture-2026-09-12-170304 Capture-2026-09-12-170316 Capture-2026-09-12-170328

After:

Capture-2026-09-12-170136 Capture-2026-09-12-170154 Capture-2026-09-12-170212 Capture-2026-09-12-170227

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@sanne-san
sanne-san added this pull request to stack #6674 September 12, 2026 14:39
@github-actions

Copy link
Copy Markdown
Preview environment👷🏼‍♀️🏗️
PR-6673

@sanne-san
sanne-san requested a review from a team September 14, 2026 06:53
Base automatically changed from sanne-favicon-placeholder to master September 15, 2026 12:52
- Fallback icons were stuck on one fixed gray, because an SVG inside an `<img>`
  cannot see the `dark` class; the browser and OS icons are now inline, and the
  link favicon has a dark variant
- All report icons share one line style, and follow the same color scheme
- Slightly reduce the stroke width in the report icons and the site placeholder
@sanne-san
sanne-san added this pull request to the merge queue Sep 15, 2026
Merged via the queue into master with commit 04ed48c Sep 15, 2026
23 checks passed
@sanne-san
sanne-san deleted the sanne-report-icons branch September 15, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants