Skip to content

Add proxy server configuration for Chromium - #304

Open
ColumbusLabs wants to merge 2 commits into
plotly:mainfrom
ColumbusLabs:codex/chromium-proxy-server
Open

Add proxy server configuration for Chromium#304
ColumbusLabs wants to merge 2 commits into
plotly:mainfrom
ColumbusLabs:codex/chromium-proxy-server

Conversation

@ColumbusLabs

@ColumbusLabs ColumbusLabs commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • add a proxy_server browser option that forwards Chromium's --proxy-server flag
  • use CHOREO_PROXY_SERVER when the explicit option is omitted or empty, including for Plotly and Kaleido callers that construct Choreographer internally
  • add focused regression coverage for explicit, environment, precedence, empty, and unset configurations

Closes #301

Testing

  • pytest -v tests/test_chromium.py (6 passed)
  • ruff check --ignore CPY001 src/choreographer/browsers/chromium.py tests/test_chromium.py
  • ruff format --check src/choreographer/browsers/chromium.py tests/test_chromium.py
  • pyright
  • mypy src/choreographer/browsers/chromium.py tests/test_chromium.py
  • git diff --check

The full local poe test browser suite cannot complete on this macOS 26 machine because the repository-pinned Chrome 142 build exits during startup with chrome_crashpad_handler: --database is required. The same test_watchdog[headless] failure reproduces from an untouched origin/main worktree; the focused proxy tests and all non-browser checks above pass.

@camdecoster camdecoster self-assigned this Jul 28, 2026
@camdecoster

Copy link
Copy Markdown
Contributor

Thanks for the PR! I'll review and follow up.

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Could you please make the requested changes and tag me for another review when you're done?

Comment thread src/choreographer/browsers/chromium.py Outdated
Comment thread src/choreographer/browsers/chromium.py
Comment thread README.md Outdated
@ColumbusLabs

Copy link
Copy Markdown
Author

Addressed the three requested changes in f2432d0: the explicit option now falls back to CHOREO_PROXY_SERVER when falsy, proxy values are no longer redacted in logs, and the README section has been removed. I also updated the focused tests for None and empty-string fallback behavior. @camdecoster, this is ready for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fig.to_image stuck in process on UNIX (behind Proxy)

2 participants