Skip to content

Change config UI - #8

Open
Lainow wants to merge 21 commits into
mainfrom
change-config-ui
Open

Change config UI#8
Lainow wants to merge 21 commits into
mainfrom
change-config-ui

Conversation

@Lainow

@Lainow Lainow commented May 27, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Change to the configuration interface (switch from checkboxes to “Yes”/‘No’ options with the “Inheritance” option)

Screenshots (if appropriate):

image image

@Lainow
Lainow requested a review from stonebuzz May 27, 2026 14:46
@Lainow Lainow self-assigned this May 27, 2026
Rom1-B
Rom1-B requested changes May 29, 2026
View reviewed changes

@Rom1-B Rom1-B left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI

@Lainow
Lainow requested a review from Rom1-B June 4, 2026 07:51
stonebuzz
stonebuzz requested changes Jun 5, 2026
View reviewed changes
Comment thread src/Config.php
Comment thread src/Config.php
Comment thread src/Config.php
Comment thread tests/Units/ConfigTest.php
stonebuzz
stonebuzz requested changes Jun 22, 2026
View reviewed changes
Comment thread src/Config.php Outdated
Comment thread tests/Units/ConfigTest.php
Comment thread src/Config.php Outdated
@Lainow
Lainow requested a review from stonebuzz June 29, 2026 13:12
stonebuzz
stonebuzz requested changes Jun 29, 2026
View reviewed changes
Comment thread src/Config.php Outdated
@stonebuzz
stonebuzz requested a review from Rom1-B June 29, 2026 13:49
@Lainow
Lainow requested a review from stonebuzz June 30, 2026 08:12
Rom1-B
Rom1-B requested changes Jun 30, 2026
View reviewed changes

@Rom1-B Rom1-B left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint

@Lainow
Lainow requested a review from Rom1-B June 30, 2026 09:47
Rom1-B
Rom1-B requested changes Jul 1, 2026
View reviewed changes
Comment thread src/Config.php Outdated
Comment thread src/Config.php Outdated
Comment thread src/Controller.php Outdated
Comment thread src/Controller.php
Lainow and others added 3 commits July 1, 2026 11:47
@Lainow @Rom1-B
Update src/Config.php
3ab0e34 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow @Rom1-B
Update src/Controller.php
fca8018 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow
Implement suggestions
02af14b
@Lainow
Lainow requested a review from Rom1-B July 1, 2026 10:07
stonebuzz
stonebuzz requested changes Jul 1, 2026
View reviewed changes
Comment thread src/Config.php Outdated
@Lainow
Lainow requested a review from stonebuzz July 1, 2026 15:26
Rom1-B
Rom1-B requested changes Jul 3, 2026
View reviewed changes
Comment thread tests/Units/ConfigTest.php
@Lainow
Lainow force-pushed the change-config-ui branch from c5f02ef to 4a9dd6d Compare July 3, 2026 09:20
@Lainow
Lainow requested a review from Rom1-B July 27, 2026 09:54
Rom1-B
Rom1-B requested changes Jul 27, 2026
View reviewed changes
Comment thread tests/Units/ConfigTest.php
Comment thread src/Config.php Outdated
Comment thread templates/config.html.twig Outdated
Lainow and others added 2 commits July 28, 2026 11:22
@Lainow @Rom1-B
Update templates/config.html.twig
610b1c0 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow @Rom1-B
Update src/Config.php
cb9a036 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow
Lainow requested a review from Rom1-B July 28, 2026 09:22
Rom1-B
Rom1-B requested changes Jul 28, 2026
View reviewed changes

@Rom1-B Rom1-B left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See preview comments

Lainow and others added 3 commits July 29, 2026 11:13
@Lainow @Rom1-B
Update tests/Units/ConfigTest.php
c7ca66a 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow
Fix cI
95a2b0b
@Lainow
Fix units tests
b38f77f
@Lainow
Lainow requested a review from Rom1-B July 29, 2026 12:28
Rom1-B
Rom1-B reviewed Jul 31, 2026
View reviewed changes
Comment thread templates/config.html.twig
@Lainow
Lainow requested a review from Rom1-B August 5, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes
@stonebuzz stonebuzz Awaiting requested review from stonebuzz

Requested changes must be addressed to merge this pull request.

Assignees

@Lainow Lainow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lainow @stonebuzz @Rom1-B