fix(Autofocus): guard depthPickingPass/copyPass against double dispose - #354
Merged
Conversation
This was referenced Jul 29, 2026
kvvasuu
force-pushed
the
fix/04-autofocus-double-dispose
branch
from
July 30, 2026 20:31
a3942cd to
f47e35c
Compare
kvvasuu
force-pushed
the
fix/04-autofocus-double-dispose
branch
2 times, most recently
from
July 31, 2026 20:29
e61f405 to
33d0938
Compare
Base automatically changed from
fix/03-effectcomposer-leak-and-reorder
to
master
July 31, 2026 20:33
EffectComposerImpl.dispose() disposes every pass it holds, including these two added via composer.addPass - if Autofocus unmounts alongside its ancestor EffectComposer, its own cleanup disposed them a second time. This collision only becomes reachable now that the composer lifecycle fix (previous commit) actually disposes the composer on unmount - previously it leaked and never disposed at all, so it never collided with Autofocus's own cleanup.
kvvasuu
force-pushed
the
fix/04-autofocus-double-dispose
branch
from
July 31, 2026 20:33
33d0938 to
9f798fc
Compare
Member
|
This looks over complicated to me but I guess lets get a robust solution before a simple one. |
krispya
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EffectComposerImpl.dispose() disposes every pass it holds, including these two added via composer.addPass - if Autofocus unmounts alongside its ancestor EffectComposer, its own cleanup disposed them a second time. This collision only becomes reachable now that the composer lifecycle fix (previous commit) actually disposes the composer on unmount - previously it leaked and never disposed at all, so it never collided with Autofocus's own cleanup.