Skip to content

test: add smoke coverage for every effect component - #356

Merged
kvvasuu merged 1 commit into
masterfrom
fix/06-effects-smoke-tests
Jul 31, 2026
Merged

test: add smoke coverage for every effect component#356
kvvasuu merged 1 commit into
masterfrom
fix/06-effects-smoke-tests

Conversation

@kvvasuu

@kvvasuu kvvasuu commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Stacked PR 6/6 — part of a split of #350.
← based on #355

Mounts each effect with minimal props inside a real EffectComposer and checks it doesn't crash and disposes correctly; a coverage test fails CI if a new file under src/effects isn't added to the manifest or the exclusion list, so this can't silently go stale as effects are added.

@kvvasuu
kvvasuu requested a review from krispya July 29, 2026 18:27
@kvvasuu
kvvasuu force-pushed the fix/06-effects-smoke-tests branch from cad98cb to 7ba58ab Compare July 30, 2026 20:31
@kvvasuu
kvvasuu force-pushed the fix/06-effects-smoke-tests branch from 7ba58ab to eb436fe Compare July 30, 2026 21:33
@kvvasuu
kvvasuu force-pushed the fix/06-effects-smoke-tests branch from eb436fe to 51b2805 Compare July 31, 2026 20:29
@kvvasuu
kvvasuu force-pushed the fix/06-effects-smoke-tests branch from 51b2805 to 14ffea3 Compare July 31, 2026 20:33
@kvvasuu
kvvasuu force-pushed the fix/06-effects-smoke-tests branch from 14ffea3 to e58337e Compare July 31, 2026 21:07
Base automatically changed from fix/05-primitive-effect-dispose to master July 31, 2026 21:08
Mounts each effect with minimal props inside a real EffectComposer and
checks it doesn't crash and disposes correctly; a coverage test fails
CI if a new file under src/effects isn't added to the manifest or the
exclusion list, so this can't silently go stale as effects are added.
@kvvasuu
kvvasuu force-pushed the fix/06-effects-smoke-tests branch from e58337e to 79e0b05 Compare July 31, 2026 21:08
@kvvasuu
kvvasuu merged commit 144a3a3 into master Jul 31, 2026
1 check passed
@kvvasuu
kvvasuu deleted the fix/06-effects-smoke-tests branch July 31, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants